Skip to content

feat: tab templates and geolocation polyfill for webviews #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dp-pcs wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: tab templates and geolocation polyfill for webviews #3263

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82dc0a9
feat: tab templates and geolocation polyfill for webviews
dp-pcs Apr 30, 2026
792c790
fix: remove geolocation (didn't work), address CodeRabbit review
dp-pcs Apr 30, 2026
d94ec6c
refactor: extract applyTabTransition helper, surface template errors
dp-pcs Apr 30, 2026
9921300
fix: always show tab menu so Manage Templates is always accessible
dp-pcs Apr 30, 2026
1117c9a
fix: surface template errors through MessageModal instead of console …
dp-pcs Apr 30, 2026
7dd9e6c
fix: defer scroll update until tabIds state reflects new tab
dp-pcs Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: extract applyTabTransition helper, surface template errors 
- Extract repeated tab UI bookkeeping into applyTabTransition()
- Add try/catch inside CreateTabFromTemplate click handler so errors
  are logged rather than silently swallowed by fireAndForget

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
@dp-pcs @claude
dp-pcs and claude committed Apr 30, 2026
commit d94ec6c8d3560f8b481ead9a10103613b5f78903
31 changes: 14 additions & 17 deletions frontend/app/tab/tabbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,11 @@ const TabBar = memo(({ workspace, noTabs }: TabBarProps) => {
[]
);

const applyTabTransition = useCallback(() => {
tabsWrapperRef.current?.style.setProperty("--tabs-wrapper-transition", "width 0.1s ease");
updateScrollDebounced();
}, [updateScrollDebounced]);

const handleAddTab = (e: React.MouseEvent) => {
fireAndForget(async () => {
try {
Expand All @@ -542,11 +547,7 @@ const TabBar = memo(({ workspace, noTabs }: TabBarProps) => {
label: "New Tab",
click: () => {
env.electron.createTab();
tabsWrapperRef.current?.style.setProperty(
"--tabs-wrapper-transition",
"width 0.1s ease"
);
updateScrollDebounced();
applyTabTransition();
setNewTabIdDebounced(null);
},
},
Expand All @@ -558,12 +559,12 @@ const TabBar = memo(({ workspace, noTabs }: TabBarProps) => {
label: t.name,
click: () => {
fireAndForget(async () => {
await TabTemplateService.CreateTabFromTemplate(workspace.oid, t.oid);
tabsWrapperRef.current?.style.setProperty(
"--tabs-wrapper-transition",
"width 0.1s ease"
);
updateScrollDebounced();
try {
await TabTemplateService.CreateTabFromTemplate(workspace.oid, t.oid);
applyTabTransition();
} catch (err) {
console.error("Failed to create tab from template:", err);
}
});
},
})),
Expand All @@ -578,18 +579,14 @@ const TabBar = memo(({ workspace, noTabs }: TabBarProps) => {
];
env.showContextMenu(menu, e);
} else {
// No templates, just create a new tab directly
env.electron.createTab();
tabsWrapperRef.current?.style.setProperty("--tabs-wrapper-transition", "width 0.1s ease");
updateScrollDebounced();
applyTabTransition();
setNewTabIdDebounced(null);
}
} catch (err) {
console.error("Failed to load templates:", err);
// Fall back to creating a new tab directly
env.electron.createTab();
tabsWrapperRef.current?.style.setProperty("--tabs-wrapper-transition", "width 0.1s ease");
updateScrollDebounced();
applyTabTransition();
setNewTabIdDebounced(null);
}
});
Expand Down