Skip to content

migrate old file streaming to new modern interface (w/ flow control) #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 7 commits into from
Mar 24, 2026
Merged

migrate old file streaming to new modern interface (w/ flow control) #3096

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fb48669
switch file cat to use new modern streaming, remove file limit
sawka Mar 20, 2026
5a83c6f
remove filereadstreamcommand
sawka Mar 20, 2026
09cf58e
file copy to also use modern streaming
sawka Mar 20, 2026
65da1bd
remove unused
sawka Mar 20, 2026
5d0b442
remove old file streaming for modern for wshfs.Read() call
sawka Mar 20, 2026
09b4f7c
remove old style file streaming call
sawka Mar 20, 2026
68dce2f
remove "modern" comment now that it is the only one
sawka Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused
  • Loading branch information
@sawka
sawka committed Mar 20, 2026
commit 65da1bddec31ec8e7736a3043528fca5ffd32e0d
9 changes: 0 additions & 9 deletions pkg/remote/fileshare/wshfs/wshfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,6 @@ func Read(ctx context.Context, data wshrpc.FileData) (*wshrpc.FileData, error) {
return fsutil.ReadStreamToFileData(ctx, rtnCh)
}

func ReadStream(ctx context.Context, data wshrpc.FileData) <-chan wshrpc.RespOrErrorUnion[wshrpc.FileData] {
log.Printf("ReadStream: %v", data.Info.Path)
conn, err := parseConnection(ctx, data.Info.Path)
if err != nil {
return wshutil.SendErrCh[wshrpc.FileData](err)
}
return readStream(conn, data)
}

func readStream(conn *connparse.Connection, data wshrpc.FileData) <-chan wshrpc.RespOrErrorUnion[wshrpc.FileData] {
byteRange := ""
if data.At != nil && data.At.Size > 0 {
Expand Down