Skip to content

fix: search bar clipboard and focus improvements #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 2 commits into from
Mar 10, 2026
Merged

fix: search bar clipboard and focus improvements #3025

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c7392e
fix: skip copy-on-select when search bar has focus
Shay12tg Mar 10, 2026
1c106fb
fix: refocus search input on repeated Cmd+F
Shay12tg Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: skip copy-on-select when search bar has focus 
Navigating search results in the terminal causes xterm.js to change the
selection programmatically, which was triggering copy-on-select and
clobbering the clipboard. Skip the clipboard write when an element
inside .search-container is the active element.
  • Loading branch information
@Shay12tg
Shay12tg committed Mar 10, 2026
commit 0c7392ec7a92d9d82942bf58d86a6b017d3d2be7
6 changes: 6 additions & 0 deletions frontend/app/view/term/termwrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,12 @@ export class TermWrap {
if (!globalStore.get(copyOnSelectAtom)) {
return;
}
// Don't copy-on-select when the search bar has focus — navigating
// search results changes the terminal selection programmatically.
const active = document.activeElement;
if (active != null && active.closest(".search-container") != null) {
return;
}
const selectedText = this.terminal.getSelection();
if (selectedText.length > 0) {
navigator.clipboard.writeText(selectedText);
Expand Down