Skip to content

preview updates (mock electron api, wos checks) #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 12 commits into from
Mar 7, 2026
Merged

preview updates (mock electron api, wos checks) #2986

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dba46ec
Initial plan
Copilot Mar 2, 2026
99bb4a6
feat: add vertical tab bar components and preview
Copilot Mar 2, 2026
189338b
fix: refine vtabbar drag drop indicators
Copilot Mar 2, 2026
c53ef4a
fix: prevent vtabbar drop line layout jump
Copilot Mar 2, 2026
d8063d8
fix: polish vertical tab indicator and close affordance
Copilot Mar 2, 2026
433f3c8
Merge remote-tracking branch 'origin/main' into sawka/preview-updates
sawka Mar 2, 2026
59612f4
mock the electronapi, and wos. set up global atoms for preview
sawka Mar 2, 2026
13bed12
updates for telemetry update
sawka Mar 2, 2026
00a1d26
Merge remote-tracking branch 'origin/main' into sawka/preview-updates
sawka Mar 5, 2026
f4f10a6
Merge remote-tracking branch 'origin/main' into sawka/preview-updates
sawka Mar 7, 2026
ea20da0
add missing method
sawka Mar 7, 2026
897660a
update skill to say to edit the preview stub
sawka Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update skill to say to edit the preview stub
  • Loading branch information
@sawka
sawka committed Mar 7, 2026
commit 897660a57d6ce4707b5d1dc4ee6cde8cc867a875
14 changes: 12 additions & 2 deletions .kilocode/skills/electron-api/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@ description: Guide for adding new Electron APIs to Wave Terminal. Use when imple

Electron APIs allow the frontend to call Electron main process functionality directly via IPC.

## Three Files to Edit
## Four Files to Edit

1. [`frontend/types/custom.d.ts`](frontend/types/custom.d.ts) - TypeScript [`ElectronApi`](frontend/types/custom.d.ts:82) type
2. [`emain/preload.ts`](emain/preload.ts) - Expose method via `contextBridge`
3. [`emain/emain-ipc.ts`](emain/emain-ipc.ts) - Implement IPC handler
4. [`frontend/preview/preview-electron-api.ts`](frontend/preview/preview-electron-api.ts) - Add a no-op stub to keep the `previewElectronApi` object in sync with the `ElectronApi` type

## Three Communication Patterns

Expand Down Expand Up @@ -54,7 +55,15 @@ electron.ipcMain.handle("capture-screenshot", async (event, rect) => {
});
```

### 4. Call from Frontend
### 4. Add Preview Stub

In [`frontend/preview/preview-electron-api.ts`](frontend/preview/preview-electron-api.ts):

```typescript
captureScreenshot: (_rect: Electron.Rectangle) => Promise.resolve(""),
```

### 5. Call from Frontend

```typescript
import { getApi } from "@/store/global";
Expand Down Expand Up @@ -167,6 +176,7 @@ webContents.send("zoom-factor-change", newZoomFactor);
- [ ] Include IPC channel name in comment
- [ ] Expose in [`preload.ts`](emain/preload.ts)
- [ ] Implement in [`emain-ipc.ts`](emain/emain-ipc.ts)
- [ ] Add no-op stub to [`preview-electron-api.ts`](frontend/preview/preview-electron-api.ts)
- [ ] IPC channel names match exactly
- [ ] **For sync**: Set `event.returnValue` (or browser hangs!)
- [ ] Test end-to-end
Loading