-
-
Notifications
You must be signed in to change notification settings - Fork 933
Remove mock-heavy OSC52 Vitest coverage #2975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| import { beforeEach, describe, expect, it, vi } from "vitest"; | ||
|
|
||
| const { mockWriteText, mockGet } = vi.hoisted(() => ({ | ||
| mockWriteText: vi.fn(), | ||
| mockGet: vi.fn(), | ||
| })); | ||
|
|
||
| vi.mock("@/app/store/wshclientapi", () => ({ RpcApi: {} })); | ||
| vi.mock("@/app/store/wshrpcutil", () => ({ TabRpcClient: {} })); | ||
| vi.mock("@/store/services", () => ({})); | ||
| vi.mock("@/store/global", () => ({ | ||
| getApi: vi.fn(), | ||
| getBlockMetaKeyAtom: vi.fn(), | ||
| getBlockTermDurableAtom: vi.fn(), | ||
| getOverrideConfigAtom: vi.fn((_blockId: string, key: string) => ({ key })), | ||
| globalStore: { get: mockGet }, | ||
| recordTEvent: vi.fn(), | ||
| WOS: {}, | ||
| })); | ||
| vi.mock("@/util/util", () => ({ | ||
| base64ToString: (data: string) => Buffer.from(data, "base64").toString("utf8"), | ||
| fireAndForget: (fn: () => Promise<void>) => { | ||
| void fn(); | ||
| }, | ||
| isSshConnName: vi.fn(), | ||
| isWslConnName: vi.fn(), | ||
| })); | ||
|
|
||
| import { handleOsc52Command } from "./osc-handlers"; | ||
|
|
||
| describe("handleOsc52Command", () => { | ||
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| mockWriteText.mockResolvedValue(undefined); | ||
| Object.defineProperty(globalThis, "navigator", { | ||
| configurable: true, | ||
| value: { clipboard: { writeText: mockWriteText } }, | ||
| }); | ||
| Object.defineProperty(globalThis, "document", { | ||
| configurable: true, | ||
| value: { hasFocus: () => true }, | ||
| }); | ||
| }); | ||
|
|
||
| it("rejects unfocused block when term:osc52 is focus", () => { | ||
| mockGet.mockImplementation((atom: { key?: string } | undefined) => { | ||
| if (atom?.key === "term:osc52") { | ||
| return "focus"; | ||
| } | ||
| return false; | ||
| }); | ||
|
|
||
| handleOsc52Command("c;SGVsbG8=", "block-1", true, { nodeModel: { isFocused: {} } } as any); | ||
|
|
||
| expect(mockWriteText).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it("allows unfocused block when term:osc52 is always", async () => { | ||
| mockGet.mockImplementation((atom: { key?: string } | undefined) => { | ||
| if (atom?.key === "term:osc52") { | ||
| return "always"; | ||
| } | ||
| return false; | ||
| }); | ||
|
|
||
| handleOsc52Command("c;SGVsbG8=", "block-1", true, { nodeModel: { isFocused: {} } } as any); | ||
| await Promise.resolve(); | ||
|
|
||
| expect(mockWriteText).toHaveBeenCalledWith("Hello"); | ||
| }); | ||
|
|
||
| it("allows write when term:osc52 is always and window is unfocused", async () => { | ||
| Object.defineProperty(globalThis, "document", { | ||
| configurable: true, | ||
| value: { hasFocus: () => false }, | ||
| }); | ||
| mockGet.mockImplementation((atom: { key?: string } | undefined) => { | ||
| if (atom?.key === "term:osc52") { | ||
| return "always"; | ||
| } | ||
| return false; | ||
| }); | ||
|
|
||
| handleOsc52Command("c;SGVsbG8=", "block-1", true, { nodeModel: { isFocused: {} } } as any); | ||
| await Promise.resolve(); | ||
|
|
||
| expect(mockWriteText).toHaveBeenCalledWith("Hello"); | ||
| }); | ||
|
|
||
| it("defaults term:osc52 to always when unset", async () => { | ||
| Object.defineProperty(globalThis, "document", { | ||
| configurable: true, | ||
| value: { hasFocus: () => false }, | ||
| }); | ||
| mockGet.mockImplementation((atom: { key?: string } | undefined) => { | ||
| if (atom?.key === "term:osc52") { | ||
| return undefined; | ||
| } | ||
| return false; | ||
| }); | ||
|
|
||
| handleOsc52Command("c;SGVsbG8=", "block-1", true, { nodeModel: { isFocused: {} } } as any); | ||
| await Promise.resolve(); | ||
|
|
||
| expect(mockWriteText).toHaveBeenCalledWith("Hello"); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Test mock may not accurately represent the actual atom behavior
The
isFocusedfield is being set to an empty object{}, but in the actual implementation (line 127 of osc-handlers.ts),globalStore.get(termWrap.nodeModel.isFocused)expects an atom. The test currently passes because the mock's default return value isfalse, not because it's properly testing an unfocused atom.Consider creating a proper mock atom that explicitly returns
falsewhen accessed viaglobalStore.get()to make the test more robust and clear about what it's testing.