Skip to content

update eslint to v9 (and fix all eslint errors) #2923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 7 commits into from
Feb 24, 2026
Merged

update eslint to v9 (and fix all eslint errors) #2923

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a7a7fb
update eslint to v9
sawka Feb 24, 2026
235c70e
fix eslint flat config, add globals
sawka Feb 24, 2026
767be19
fix a lot of eslint issues, much more expansive eslint config
sawka Feb 24, 2026
5ae9626
fix more eslint errors
sawka Feb 24, 2026
3d3751a
all of emain is node
sawka Feb 24, 2026
810cf2e
fix final (all) eslint errors
sawka Feb 24, 2026
20f220f
remove bad comment
sawka Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,11 @@
"@docusaurus/module-type-aliases": "3.9.2",
"@docusaurus/tsconfig": "3.9.2",
"@docusaurus/types": "3.9.2",
"@eslint/js": "^8.57.0",
"@eslint/js": "^9.39",
"@mdx-js/typescript-plugin": "^0.1.3",
"@types/eslint": "^9.6.1",
"@types/eslint-config-prettier": "^6.11.3",
"@types/react": "^18.3.0",
"@types/react-dom": "^18.3.0",
"eslint": "^8.57.0",
"eslint": "^9.39",
"eslint-config-prettier": "^10.1.8",
"eslint-plugin-mdx": "^3.6.2",
"prettier": "^3.8.1",
Expand All @@ -56,7 +54,7 @@
"remark-preset-lint-consistent": "^6.0.1",
"remark-preset-lint-recommended": "^7.0.1",
"typescript": "^5.9.3",
"typescript-eslint": "^8.54.0"
"typescript-eslint": "^8.56"
},
"resolutions": {
"path-to-regexp@npm:2.2.1": "^3",
Expand Down
23 changes: 12 additions & 11 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,21 @@

import eslint from "@eslint/js";
import eslintConfigPrettier from "eslint-config-prettier";
import globals from "globals";
import tseslint from "typescript-eslint";

const baseConfig = tseslint.config(eslint.configs.recommended, ...tseslint.configs.recommended);
export default [
eslint.configs.recommended,
...tseslint.configs.recommended,

const customConfig = {
...baseConfig,
overrides: [
{
files: ["emain/emain.ts", "electron.vite.config.ts"],
env: {
node: true,
{
files: ["emain/emain.ts", "electron.vite.config.ts"],
languageOptions: {
globals: {
...globals.node,
},
},
],
};
},

export default [customConfig, eslintConfigPrettier];
eslintConfigPrettier,
];
Loading