Skip to content

Refine global atom split: keep atom init in global-atoms.ts, move About-menu wiring back to global.ts #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 3 commits into from
Feb 24, 2026
Merged

Refine global atom split: keep atom init in global-atoms.ts, move About-menu wiring back to global.ts #2900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeddd7f
Initial plan
Copilot Feb 20, 2026
27e7e95
Refactor global atom ownership into global-atoms
Copilot Feb 20, 2026
672853e
Move About menu hook back to global init
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Move About menu hook back to global init 
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
  • Loading branch information
@sawka
Copilot and sawka committed Feb 20, 2026
commit 672853e9518a7d571af137ff6cf65c44f217bb51
9 changes: 0 additions & 9 deletions frontend/app/store/global-atoms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import { atom, Atom, PrimitiveAtom } from "jotai";
import { globalStore } from "./jotaiStore";
import { modalsModel } from "./modalmodel";
import * as WOS from "./wos";

let atoms!: GlobalAtomsType;
Expand Down Expand Up @@ -47,14 +46,6 @@ function initGlobalAtoms(initOpts: GlobalInitOptions) {
console.log("failed to initialize zoomFactorAtom", e);
}

try {
getApi().onMenuItemAbout(() => {
modalsModel.pushModal("AboutModal");
});
} catch (e) {
console.log("failed to initialize onMenuItemAbout handler", e);
}

const workspaceAtom: Atom<Workspace> = atom((get) => {
const windowData = WOS.getObjectValue<WaveWindow>(WOS.makeORef("window", get(windowIdAtom)), get);
if (windowData == null) {
Expand Down
7 changes: 7 additions & 0 deletions frontend/app/store/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,13 @@ function initGlobal(initOpts: GlobalInitOptions) {
globalPrimaryTabStartup = initOpts.primaryTabStartup ?? false;
setPlatform(initOpts.platform);
initGlobalAtoms(initOpts);
try {
getApi().onMenuItemAbout(() => {
modalsModel.pushModal("AboutModal");
});
} catch (e) {
console.log("failed to initialize onMenuItemAbout handler", e);
}
}

function initGlobalWaveEventSubs(initOpts: WaveInitOpts) {
Expand Down
Loading