[FedCM] Specify third party iframe display support#774
Merged
npm1 merged 6 commits intow3c-fedid:mainfrom Oct 8, 2025
Merged
Conversation
Collaborator
Author
|
I think this is ready for review now |
TallTed
suggested changes
Aug 26, 2025
Comment on lines
+1631
to
+1634
| 1. If |metadata| is not null or failure, and |metadata|. | ||
| {{IdentityProviderClientMetadata/client_matches_top_frame_origin}} is `false`, this dialog | ||
| MUST show the [=host/registrable domain=] of |globalObject|'s [=associated Document=]'s | ||
| [=Document/origin=] to the user. |
Contributor
There was a problem hiding this comment.
Eliminating the space that will otherwise appear between |metadata|. and {{ —
Suggested change
| 1. If |metadata| is not null or failure, and |metadata|. | |
| {{IdentityProviderClientMetadata/client_matches_top_frame_origin}} is `false`, this dialog | |
| MUST show the [=host/registrable domain=] of |globalObject|'s [=associated Document=]'s | |
| [=Document/origin=] to the user. | |
| 1. If |metadata| is not null or failure, and | |
| |metadata|.{{IdentityProviderClientMetadata/client_matches_top_frame_origin}} | |
| is `false`, this dialog | |
| MUST show the [=host/registrable domain=] of |globalObject|'s | |
| [=associated Document=]'s [=Document/origin=] to the user. |
Collaborator
Author
There was a problem hiding this comment.
Thanks, commited a variant of that.
npm1
reviewed
Aug 28, 2025
Closed
2 tasks
Collaborator
Author
|
@pottis could you review this PR as well? |
npm1
reviewed
Sep 10, 2025
npm1
approved these changes
Oct 7, 2025
| |provider|'s {{IdentityProviderConfig/configURL}}. | ||
| 1. Set |permission| to the result of running the [=request permission to | ||
| sign-up=] algorithm with |selectedAccount|, the relevant |provider|, | ||
| |clientMetadataMap|[|providerOrigin|], and |globalObject|. |
Collaborator
There was a problem hiding this comment.
The map was set with configURL as key and now it is using origin? Which one is it
Collaborator
Author
There was a problem hiding this comment.
?
it was set as (line 1091):
|rpOrigin|, set |clientMetadataMap|[|providerOrigin|] to the result of running [=fetch the client metadata=] with
But I actually changed it to configURL because that is a bit simpler.
| @@ -1080,6 +1081,19 @@ When asked to <dfn for="create identity credential">fetch accounts</dfn> given a | |||
| <div class="issue" heading="extension"> | |||
| An extension may use the following instead of the [=create identity credential/show accounts=] step, where | |||
Collaborator
There was a problem hiding this comment.
Maybe wrap these in div algorithm to get things like variable highlighting?
Collaborator
Author
There was a problem hiding this comment.
Done although that wasn't new. Fixed some bikeshed warnings that were triggered by this.
pottis
approved these changes
Oct 8, 2025
github-actions Bot
added a commit
that referenced
this pull request
Oct 8, 2025
SHA: 3d1f48b Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Oct 8, 2025
SHA: 3d1f48b Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: #725
Preview | Diff