Skip to content

Change URL of GitHub CDN - #310

Merged
vsch merged 1 commit into
vsch:masterfrom
benelog:change-github-cdn
Feb 22, 2019
Merged

Change URL of GitHub CDN#310
vsch merged 1 commit into
vsch:masterfrom
benelog:change-github-cdn

Conversation

@benelog

@benelog benelog commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

The URL of Github CDN has changed from https://assets-cdn.github.com to https://github.githubassets.com/ . Old URLs return 404 (not found) now.

( For example : https://assets-cdn.github.com/images/icons/emoji/unicode/26a0.png?v7 -> https://github.githubassets.com/images/icons/emoji/unicode/26a0.png?v7 )

This PR fixes that problem.

@benelog

benelog commented Feb 22, 2019

Copy link
Copy Markdown
Contributor Author

A test is failed on master branch.

Failed tests:   testFullSpec(com.vladsch.flexmark.test.FullOrigSpecCoreTest): expected:<...``` ~~~(..)

Tests run: 3969, Failures: 1, Errors: 0, Skipped: 15

@vsch

vsch commented Feb 22, 2019

Copy link
Copy Markdown
Owner

@benelog, thank you for the PR, the failure is caused by me adding a new spec.txt from CommonMark before I implemented the changes to support it and then accidentally pushing my local changes to GitHub.

I'll merge and then fix the build.

@vsch
vsch merged commit a82c83a into vsch:master Feb 22, 2019
@vsch

vsch commented Feb 23, 2019

Copy link
Copy Markdown
Owner

@benelog, repo updated and a new maven release is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants