Skip to content

Flatten BoundKind into BoundExpression - #9256

Draft
mhk197 wants to merge 1 commit into
mk/root-expressionfrom
mk/bound-expression-enum
Draft

Flatten BoundKind into BoundExpression#9256
mhk197 wants to merge 1 commit into
mk/root-expressionfrom
mk/bound-expression-enum

Conversation

@mhk197

@mhk197 mhk197 commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Collapses BoundExpression { kind: BoundKind, dtype } into a single enum, with dtype on each variant.

pub enum BoundExpression {
    Scalar { dtype: DType, scalar_fn: ScalarFnRef, children: Arc<Vec<BoundExpression>> },
    Root { dtype: DType },
}

This is a prerequisite for lambdas, which have no dtype but should be a variant.

@mhk197 mhk197 added the changelog/skip Do not list PR in the changelog label Aug 7, 2026
@mhk197 mhk197 changed the title flatten BoundKind into BoundExpression Flatten BoundKind into BoundExpression Aug 7, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 1017 untouched benchmarks
⏩ 963 skipped benchmarks1

Comparing mk/bound-expression-enum (9296dac) with mk/root-expression (996a4e3)2

Open in CodSpeed

Footnotes

  1. 963 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on mk/root-expression (8bd1b1f) during the generation of this report, so 1fd8422 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@mhk197 mhk197 mentioned this pull request Aug 7, 2026
Draft
@mhk197
flatten BoundKind into BoundExpression
9296dac 
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197
mhk197 force-pushed the mk/bound-expression-enum branch from 93a164f to 9296dac Compare August 7, 2026 03:06
@mhk197 mhk197 added changelog/chore A trivial change and removed changelog/skip Do not list PR in the changelog labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog/chore A trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mhk197