Skip to content

duckdb: Restrict pushed aggregations - #9233

Open
myrrc wants to merge 2 commits into
developfrom
myrrc/duckdb-restrict-aggregations
Open

duckdb: Restrict pushed aggregations#9233
myrrc wants to merge 2 commits into
developfrom
myrrc/duckdb-restrict-aggregations

Conversation

@myrrc

@myrrc myrrc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
  • Forbid aggregation of Decimal sum/mean: different overflow semantics
  • Allow pushdown of aggregations over scalars i.e. min(strlen(x)).
    Forbid pushdown of aggregations over non-allowed types i.e.
    sum(strlen(x))
  • Forbid min/max of String and List since we don't have an implementation
    for that

@myrrc myrrc added changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration labels Aug 6, 2026
@myrrc
myrrc enabled auto-merge (squash) August 6, 2026 13:51
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 1925 untouched benchmarks
⏩ 51 skipped benchmarks1


Comparing myrrc/duckdb-restrict-aggregations (022d9c2) with develop (a1057db)2

Open in CodSpeed

Footnotes

  1. 51 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (6ae2a8b) during the generation of this report, so a1057db was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@myrrc
myrrc force-pushed the myrrc/duckdb-restrict-aggregations branch from d69472a to dfb9297 Compare August 6, 2026 15:58
myrrc added 2 commits August 6, 2026 17:34
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/duckdb-restrict-aggregations branch from dfb9297 to 022d9c2 Compare August 6, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant