Skip to content

take() on VarBin returns VarBinView - #9229

Open
myrrc wants to merge 3 commits into
developfrom
myrrc/varbin-take-zero-copy
Open

take() on VarBin returns VarBinView#9229
myrrc wants to merge 3 commits into
developfrom
myrrc/varbin-take-zero-copy

Conversation

@myrrc

@myrrc myrrc commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

take() on VarBin returned a VarBin which was slow because referenced bytes were
copied. However, FSST version requires this. Make take() return VarBinView but
keep the old version for FSST.

Add a take benchmark for VarBin

Resolves: #4964

@myrrc myrrc added the changelog/feature A new feature label Aug 6, 2026
@myrrc
myrrc requested a review from robert3005 August 6, 2026 12:20
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.1%

❌ 1 regressed benchmark
✅ 1900 untouched benchmarks
🆕 1 new benchmark
⏩ 43 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation decompress[u64, (1000, 16)] 64.6 µs 72.6 µs -11.1%
🆕 Simulation take_varbin N/A 1.1 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing myrrc/varbin-take-zero-copy (d5f7320) with develop (0053f78)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@myrrc
myrrc marked this pull request as draft August 6, 2026 12:33
@myrrc
myrrc force-pushed the myrrc/varbin-take-zero-copy branch from 535b0d4 to d5f7320 Compare August 6, 2026 13:56
@myrrc
myrrc marked this pull request as ready for review August 6, 2026 13:56
@myrrc myrrc changed the title Make take() on VarBin return VarBinView take() on VarBin returns VarBinView Aug 6, 2026
robert3005
robert3005 reviewed Aug 6, 2026
View reviewed changes
Comment thread encodings/fsst/src/compute/mod.rs Outdated
@myrrc
myrrc enabled auto-merge (squash) August 6, 2026 14:03
robert3005
robert3005 reviewed Aug 6, 2026
View reviewed changes
Comment thread vortex-array/src/arrays/varbin/compute/take.rs
robert3005
robert3005 reviewed Aug 6, 2026
View reviewed changes
Comment thread vortex-array/src/arrays/varbin/compute/take.rs Outdated
@myrrc
myrrc requested a review from robert3005 August 6, 2026 14:33
myrrc added 3 commits August 6, 2026 17:08
@myrrc
Make take() on VarBin return VarBinView
a815c25 
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
benchmark
7f0bfa5 
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
review
b135bde 
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc
myrrc force-pushed the myrrc/varbin-take-zero-copy branch from d5f7320 to b135bde Compare August 6, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 Awaiting requested review from robert3005

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

consider changing take for varbin

2 participants

@myrrc @robert3005