Bypass unknown aggregates in ZonedLayout#8904
Open
connortsui20 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
connortsui20
enabled auto-merge (squash)
July 22, 2026 17:36
9 tasks
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: Vortex queries 📖Verdict: Likely regression (high confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.698x ❌, 0↑ 2↓)
datafusion / parquet (1.241x ❌, 0↑ 2↓)
duckdb / vortex-file-compressed (1.379x ❌, 0↑ 2↓)
duckdb / parquet (1.104x ❌, 0↑ 1↓)
No file size changes detected. |
connortsui20
disabled auto-merge
July 22, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tracking issue: #8901
Resolves the unknown aggregate subissue.
What changes are included in this PR?
Allows us to ignore unknown aggregates in
ZonedLayoutby simply bypassing any pruning. Even if the query might be slow because of this (it will be a full scan), it is better than erroring.What APIs are changed? Are there any user-facing changes?
Changes
to_aggregate_fntoto_aggregate_fn_optandaggregate_fns_from_specstotry_aggregate_fns_from_specs