Fix vortex-jni local path handling, centralise logic in vortex-file#8650
Fix vortex-jni local path handling, centralise logic in vortex-file#8650robert3005 wants to merge 1 commit into
Conversation
Merging this PR will improve performance by 11.89%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
272.2 µs | 306.9 µs | -11.31% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
206.4 µs | 169.8 µs | +21.57% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
205.9 µs | 169.5 µs | +21.45% |
| ⚡ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
219.9 µs | 183.6 µs | +19.79% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
273.6 ns | 244.4 ns | +11.93% |
| ⚡ | Simulation | encode_varbin[(1000, 32)] |
162.4 µs | 145.3 µs | +11.79% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/vortex-spark-bare-paths-bja1ek (35ad5bf) with develop (ee2cd67)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
a2cfeab to
ecc9af6
Compare
Existing logic was duplicated between jni and duckdb with slight differences. JNI logic didn't always handle local paths. Signed-off-by: "robert" <robert@spiraldb.com> Signed-off-by: Robert Kruszewski <github@robertk.io>
ecc9af6 to
35ad5bf
Compare
Existing logic was duplicated between jni and duckdb with slight
differences. JNI logic didn't always handle local paths.