Skip to content

VortexSession register is public and allow_unknown takes reference#8647

Open
robert3005 wants to merge 2 commits into
developfrom
rk/sessionnits
Open

VortexSession register is public and allow_unknown takes reference#8647
robert3005 wants to merge 2 commits into
developfrom
rk/sessionnits

Conversation

@robert3005

@robert3005 robert3005 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

While integrating vortex into another project I realised that these are more
sensible apis

@robert3005
VortexSession register is public and allow_unknown takes reference
bd43de6 
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 requested a review from a team July 3, 2026 00:07
@codspeed-hq

codspeed-hq Bot commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will improve performance by 11.07%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 3 improved benchmarks
❌ 1 regressed benchmark
✅ 1593 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation slice_empty_vortex 339.4 ns 397.8 ns -14.66%
⚡ Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
⚡ Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
⚡ Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing rk/sessionnits (cc1bb7a) with develop (ee2cd67)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@robert3005
format
cc1bb7a 
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/feature A new feature label Jul 3, 2026
@robert3005 robert3005 enabled auto-merge (squash) July 3, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myrrc myrrc myrrc approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert3005 @myrrc