Skip to content

Initial support for VariantGet expression#7256

Open
AdamGS wants to merge 6 commits intodevelopfrom
adamg/variant-get
Open

Initial support for VariantGet expression#7256
AdamGS wants to merge 6 commits intodevelopfrom
adamg/variant-get

Conversation

@AdamGS
Copy link
Copy Markdown
Contributor

@AdamGS AdamGS commented Apr 2, 2026 •
edited
Loading

Summary

Adds a new VariantGet expression, used to extract data out of variant arrays.

The expression itself falls back to arrow for now, as a proper implementation requires some complexity that I think we can just delegate for now while we fill out other pieces.

The overall changes include:

  • variant_get / variant_get_as functions
  • VariantGet execution for ParquetVariant
  • Pushdown of VariantGet through Variant, Slice, and Filter wrappers
  • Arrow parity tests for nested paths, typed extraction, null handling, and wrapper cases.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 1153 untouched benchmarks
⏩ 1455 skipped benchmarks1

Comparing adamg/variant-get (68b59ab) with develop (0e0401c)

Open in CodSpeed

Footnotes

  1. 1455 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@AdamGS AdamGS force-pushed the adamg/variant-get branch from c98dc87 to 44f1e3b Compare April 2, 2026 08:50
@AdamGS AdamGS added the changelog/feature A new feature label Apr 2, 2026
@AdamGS AdamGS force-pushed the adamg/variant-get branch 3 times, most recently from 9d29404 to a67ddce Compare April 8, 2026 15:09
@AdamGS AdamGS force-pushed the adamg/variant-get branch 8 times, most recently from a8efc57 to ce74471 Compare April 15, 2026 12:49
AdamGS added 5 commits April 15, 2026 17:29
@AdamGS
variant get
83ab0e8 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
stuff
d019aad 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
fmt variant_get tests
1f724a7 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
Better expr
1c06acd 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS
more
abaede8 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/variant-get branch from ce74471 to abaede8 Compare April 15, 2026 16:29
@AdamGS AdamGS changed the title [WIP] VariantGet expression Initial support for VariantGet expression Apr 15, 2026
@AdamGS
Move things around
68b59ab 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS marked this pull request as ready for review April 15, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AdamGS