Send DECRQM sequences based on version response#19938
Send DECRQM sequences based on version response#1993864-bitman wants to merge 3 commits intovim:masterfrom
Conversation
|
Thank you for your PR. Please confirm two points. 1.
|
a627976 to
e008d34
Compare
|
Here are additional review comments. 1. Missing
|
|
hm, this causes quite a few test failures. Let me re-trigger CI again. |
Should be fixed |
|
there still seem to be some screen dump failures :( |
I'll try fixing them when I can (soon hopefully), it is exam season for me :/ |
|
no worries, take your time and good luck for your exams 🤞 |
|
@64-bitman I'll take over this matter. Please leave this PR as is. |
Move DECRQM request out of handle_version_response() and send it at startup via may_req_decrqm(), following the existing may_req_termresponse() and may_req_bg_color() pattern. Sending DECRQM from handle_version_response() caused DECRPM responses to arrive during user input processing, leaving bytes in typebuf when clear_showcmd() ran. This made visual-mode showcmd (e.g. "7" line count after V<C-D><C-D>) intermittently disappear, failing many screendump tests on CI. - Add decrqm_status (termrequest_T) and register it in all_termrequests[]. - Add may_req_decrqm() in the style of may_req_bg_color(). It only sends when the status is STATUS_GET and TPR_DECRQM is not TPR_NO. - Call may_req_decrqm() from vim_main2() right after may_req_bg_color(), where the original send_decrqm_modes() used to be called. - Mark decrqm_status as STATUS_GOT in the DECRPM response handler. Co-Authored-By: Hirohito Higashi <h.east.727@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Should fix #19852