Skip to content

0x9b byte not unescaped in <Cmd> mapping#19937

Closed
zeertzjq wants to merge 1 commit intovim:masterfrom
zeertzjq:cmdkey-csi
Closed

0x9b byte not unescaped in <Cmd> mapping#19937
zeertzjq wants to merge 1 commit intovim:masterfrom
zeertzjq:cmdkey-csi

Conversation

@zeertzjq
Copy link
Copy Markdown
Member

@zeertzjq zeertzjq commented Apr 8, 2026

Problem: 0x9b byte not unescaped in <Cmd> mapping.
Solution: Translate K_CSI to CSI like what is done in vgetc().

fixes: #19936

Problem:  0x9b byte not unescaped in <Cmd> mapping.
Solution: Translate K_CSI to CSI like what is done in vgetc().

fixes: vim#19936
@bennyyip
Copy link
Copy Markdown
Contributor

bennyyip commented Apr 9, 2026

I can reproduce the bug in terminal vim. Should we remove the #ifdef FEAT_GUI?

@zeertzjq
Copy link
Copy Markdown
Member Author

zeertzjq commented Apr 9, 2026

No, FEAT_GUI is a compile-time flag. That you can use Vim in a terminal doesn't mean it doesn't support GUI. This bug shouldn't happen if you use a Vim version with no GUI support at all.

@chrisbra
Copy link
Copy Markdown
Member

chrisbra commented Apr 9, 2026

thanks

@chrisbra chrisbra closed this in 3e20129 Apr 9, 2026
@zeertzjq zeertzjq deleted the cmdkey-csi branch April 9, 2026 22:38
zeertzjq added a commit to zeertzjq/neovim that referenced this pull request Apr 9, 2026
Problem:  0x9b byte not unescaped in <Cmd> mapping (BenYip).
Solution: Translate K_CSI to CSI like what is done in vgetc().
          (zeertzjq).

fixes:  vim/vim#19936
closes: vim/vim#19937

vim/vim@3e20129
zeertzjq added a commit to neovim/neovim that referenced this pull request Apr 9, 2026
Problem:  0x9b byte not unescaped in <Cmd> mapping (BenYip).
Solution: Translate K_CSI to CSI like what is done in vgetc().
          (zeertzjq).

fixes:  vim/vim#19936
closes: vim/vim#19937

vim/vim@3e20129
ellisonleao pushed a commit to ellisonleao/neovim that referenced this pull request Apr 10, 2026
…38919)

Problem:  0x9b byte not unescaped in <Cmd> mapping (BenYip).
Solution: Translate K_CSI to CSI like what is done in vgetc().
          (zeertzjq).

fixes:  vim/vim#19936
closes: vim/vim#19937

vim/vim@3e20129
MariaSolOs pushed a commit to MariaSolOs/neovim that referenced this pull request Apr 15, 2026
…38919)

Problem:  0x9b byte not unescaped in <Cmd> mapping (BenYip).
Solution: Translate K_CSI to CSI like what is done in vgetc().
          (zeertzjq).

fixes:  vim/vim#19936
closes: vim/vim#19937

vim/vim@3e20129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<cmd> and : in map have different behaviors on certain unicode text

3 participants