runtime(jjdescription): improve status line highlighting and add support for renames#19879
Closed
jstemmer wants to merge 2 commits intovim:masterfrom
Closed
runtime(jjdescription): improve status line highlighting and add support for renames#19879jstemmer wants to merge 2 commits intovim:masterfrom
jstemmer wants to merge 2 commits intovim:masterfrom
Conversation
The regex for status line highlighting was too broad, `jjComment` lines containing e.g. the letter 'A' followed by a space anywhere in the line were highlighted.
`jj status` output uses the 'R' prefix for renamed files.
Member
|
ping @gpanders |
Member
|
thanks |
chrisbra
pushed a commit
that referenced
this pull request
Apr 9, 2026
The regex for status line highlighting was too broad, `jjComment` lines containing e.g. the letter 'A' followed by a space anywhere in the line were highlighted. related: #19879 Signed-off-by: Joël Stemmer <jstemmer@google.com> Signed-off-by: Gregory Anders <greg@gpanders.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Apr 10, 2026
…tart of line The regex for status line highlighting was too broad, `jjComment` lines containing e.g. the letter 'A' followed by a space anywhere in the line were highlighted. related: vim/vim#19879 vim/vim@9598174 Co-authored-by: Joël Stemmer <jstemmer@google.com>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Apr 10, 2026
…med' status lines `jj status` output uses the 'R' prefix for renamed files. closes: vim/vim#19879 vim/vim@f554a7c Co-authored-by: Joël Stemmer <jstemmer@google.com>
Contributor
Author
|
Thanks! |
ellisonleao
pushed a commit
to ellisonleao/neovim
that referenced
this pull request
Apr 10, 2026
…tart of line The regex for status line highlighting was too broad, `jjComment` lines containing e.g. the letter 'A' followed by a space anywhere in the line were highlighted. related: vim/vim#19879 vim/vim@9598174 Co-authored-by: Joël Stemmer <jstemmer@google.com>
ellisonleao
pushed a commit
to ellisonleao/neovim
that referenced
this pull request
Apr 10, 2026
…med' status lines `jj status` output uses the 'R' prefix for renamed files. closes: vim/vim#19879 vim/vim@f554a7c Co-authored-by: Joël Stemmer <jstemmer@google.com>
MariaSolOs
pushed a commit
to MariaSolOs/neovim
that referenced
this pull request
Apr 15, 2026
…tart of line The regex for status line highlighting was too broad, `jjComment` lines containing e.g. the letter 'A' followed by a space anywhere in the line were highlighted. related: vim/vim#19879 vim/vim@9598174 Co-authored-by: Joël Stemmer <jstemmer@google.com>
MariaSolOs
pushed a commit
to MariaSolOs/neovim
that referenced
this pull request
Apr 15, 2026
…med' status lines `jj status` output uses the 'R' prefix for renamed files. closes: vim/vim#19879 vim/vim@f554a7c Co-authored-by: Joël Stemmer <jstemmer@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex for highlighting
jjstatus lines was a bit too broad, frequently highlighting lines that weren't actually status lines in my commit descriptions. I've made the regex a bit more strict to prevent this.I also added support for highlighting renamed files (these lines look like
R {old.txt => new.txt}).