Skip to content

chore: fix examples - #40395

Merged
balazsorban44 merged 2 commits into
canaryfrom
fix/issue-40366
Sep 9, 2022
Merged

balazsorban44 merged 2 commits into
canaryfrom
fix/issue-40366

Conversation

@balazsorban44

@balazsorban44 balazsorban44 commented Sep 9, 2022 •

Copy link
Copy Markdown
Contributor

Closes #40366

Rebass is not dependent on styled-components anymore. See: https://rebassjs.org/migrating/#v4-breaking-changes

Closes #40367

Document has been converted (#39871) from class, so this.props threw an error.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue was opened via the examples template. label Sep 9, 2022
@balazsorban44 balazsorban44 changed the title chore: simplify with-rebass example chore: fix examples Sep 9, 2022
@balazsorban44
balazsorban44 merged commit 13e423c into canary Sep 9, 2022
@balazsorban44
balazsorban44 deleted the fix/issue-40366 branch September 9, 2022 13:35
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

examples Issue was opened via the examples template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

with-strict-csp example doesn't run with-rebass example's _document.js does nothing

2 participants