Make clear that the Debian package is for desktop#7919
Merged
t3chguy merged 1 commit intoelement-hq:developfrom Dec 19, 2018
remram44:debian-pkg-is-electron
Merged
Make clear that the Debian package is for desktop#7919t3chguy merged 1 commit intoelement-hq:developfrom remram44:debian-pkg-is-electron
t3chguy merged 1 commit intoelement-hq:developfrom
remram44:debian-pkg-is-electron
Conversation
Member
|
I know its only a readme change but any chance of a DCO sign-off as per: https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off |
Contributor
Author
|
Signed-off! |
Member
|
/me rebases |
Member
|
Thanks for your contribution Fixes #7918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this section is just after the "Untar the tarball on your web server" instructions, I had assumed that this was a Debian package for the server. It is not completely uncommon to have packages for web apps, for example phpmyadmin is packaged for Debian.
This makes it clear that this is a desktop app, and will avoid confusion (particularly because riot-web probably won't run on a server, #7918).
Signed-off-by: Remi Rampin remirampin@gmail.com