Skip to content

Make clear that the Debian package is for desktop - #7919

Merged
t3chguy merged 1 commit into
element-hq:developfrom
remram44:debian-pkg-is-electron
Dec 19, 2018
Merged

t3chguy merged 1 commit into
element-hq:developfrom
remram44:debian-pkg-is-electron

Conversation

@remram44

@remram44 remram44 commented Dec 19, 2018 •

Copy link
Copy Markdown
Contributor

Since this section is just after the "Untar the tarball on your web server" instructions, I had assumed that this was a Debian package for the server. It is not completely uncommon to have packages for web apps, for example phpmyadmin is packaged for Debian.

This makes it clear that this is a desktop app, and will avoid confusion (particularly because riot-web probably won't run on a server, #7918).

Signed-off-by: Remi Rampin remirampin@gmail.com

@t3chguy

t3chguy commented Dec 19, 2018

Copy link
Copy Markdown
Member

I know its only a readme change but any chance of a DCO sign-off as per: https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off

@t3chguy
t3chguy changed the base branch from master to develop December 19, 2018 21:01
@remram44

Copy link
Copy Markdown
Contributor Author

Signed-off!

@t3chguy

t3chguy commented Dec 19, 2018

Copy link
Copy Markdown
Member

/me rebases

@t3chguy

t3chguy commented Dec 19, 2018

Copy link
Copy Markdown
Member

Thanks for your contribution

Fixes #7918

@t3chguy
t3chguy merged commit 6c6819f into element-hq:develop Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants