Skip to content

Feature/connect as sysdba #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pesse merged 7 commits into from
Mar 19, 2019
Merged

Feature/connect as sysdba #133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96d2464
Simple test to check if we get what we expect
pesse Mar 14, 2019
3af0122
Some simple tests to ensure parsing of special-chars User/PW is possible
pesse Mar 14, 2019
41fa06b
Support user/password containing / and @
pesse Mar 15, 2019
7fa4a72
Improvement of tests
pesse Mar 15, 2019
4207834
Update documentation how to run utPLSQL-cli as sysdba
pesse Mar 19, 2019
cb5072a
Output warning in case of connecting as SYSDBA/SYSOPER
pesse Mar 19, 2019
9b1714f
Improve documentation for connecting with special chars
pesse Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Output warning in case of connecting as SYSDBA/SYSOPER
  • Loading branch information
@pesse
pesse committed Mar 19, 2019
commit cb5072a52de3a79d8b4d308daac8fbd4ddea9424
6 changes: 6 additions & 0 deletions src/main/java/org/utplsql/cli/ConnectionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,10 @@ public String getPassword() {
public String getConnectString() {
return user + "/" + password + "@" + connect;
}

public boolean isSysDba() {
return user != null &&
(user.toLowerCase().endsWith(" as sysdba")
|| user.toLowerCase().endsWith(" as sysoper"));
}
}
7 changes: 7 additions & 0 deletions src/main/java/org/utplsql/cli/DataSourceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ public static DataSource getDataSource(ConnectionInfo info, int maxConnections )
requireOjdbc();

ConnectionConfig config = new ConnectionConfig(info.getConnectionString());
warnIfSysDba(config);

HikariDataSource pds = new TestedDataSourceProvider(config).getDataSource();
pds.setAutoCommit(false);
Expand All @@ -43,4 +44,10 @@ private static void requireOjdbc() {
throw new RuntimeException("Can't run utPLSQL-cli without Oracle JDBC driver");
}
}

private static void warnIfSysDba(ConnectionConfig config) {
if ( config.isSysDba() ) {
System.out.println("WARNING: You are connecting to the database as SYSDBA or SYSOPER, which is NOT RECOMMENDED and can put your database at risk!");
}
}
}
15 changes: 14 additions & 1 deletion src/test/java/org/utplsql/cli/ConnectionConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.*;

public class ConnectionConfigTest {

Expand All @@ -13,6 +13,7 @@ void parse() {
assertEquals("test", info.getUser());
assertEquals("pw", info.getPassword());
assertEquals("my.local.host/service", info.getConnect());
assertFalse(info.isSysDba());
}

@Test
Expand All @@ -22,6 +23,16 @@ void parseSysDba() {
assertEquals("sys as sysdba", info.getUser());
assertEquals("pw", info.getPassword());
assertEquals("my.local.host/service", info.getConnect());
assertTrue(info.isSysDba());
}
@Test
void parseSysOper() {
ConnectionConfig info = new ConnectionConfig("myOperUser as sysoper/passw0rd@my.local.host/service");

assertEquals("myOperUser as sysoper", info.getUser());
assertEquals("passw0rd", info.getPassword());
assertEquals("my.local.host/service", info.getConnect());
assertTrue(info.isSysDba());
}

@Test
Expand All @@ -31,6 +42,7 @@ void parseSpecialCharsPW() {
assertEquals("test", info.getUser());
assertEquals("p@ssw0rd=", info.getPassword());
assertEquals("my.local.host/service", info.getConnect());
assertFalse(info.isSysDba());
}

@Test
Expand All @@ -40,5 +52,6 @@ void parseSpecialCharsUser() {
assertEquals("User/Mine@=", info.getUser());
assertEquals("pw", info.getPassword());
assertEquals("my.local.host/service", info.getConnect());
assertFalse(info.isSysDba());
}
}