Skip to content

Cleanup and refactoring of annotation cache. #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 5 commits into from
Feb 23, 2020
Merged

Cleanup and refactoring of annotation cache. #986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba90abf
Cleanup and refactoring of annotation cache.
jgebal Aug 5, 2019
335e420
Fixed loophole in privilege check.
jgebal Nov 12, 2019
b39c5be
Added additional tests for annotation cache refresh with/without DDL …
jgebal Feb 17, 2020
641b3b4
Update install.sh
jgebal Feb 18, 2020
5d4c33c
Removed unneeded `is_annotated` column
jgebal Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed loophole in privilege check.
  • Loading branch information
@jgebal
jgebal committed Feb 15, 2020
commit 335e420f7a70eb60aed97909122da2c5ad91ef1a
2 changes: 1 addition & 1 deletion source/core/types/ut_executable_test.tpb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ create or replace type body ut_executable_test as
l_fail_message := 'Expected one of exceptions ('||l_expected_error_codes||') but nothing was raised.';
else
l_actual_error_no := regexp_substr(self.error_stack, '^[a-zA-Z]{3}(-[0-9]+)', subexpression=>1);
if not l_actual_error_no member of a_expected_error_codes then
if not l_actual_error_no member of a_expected_error_codes or l_actual_error_no is null then
l_fail_message := 'Actual: '||l_actual_error_no||' was expected to ';
if cardinality(a_expected_error_codes) > 1 then
l_fail_message := l_fail_message || 'be one of: ('||l_expected_error_codes||')';
Expand Down
2 changes: 1 addition & 1 deletion source/core/ut_metadata.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ create or replace package body ut_metadata as
function user_has_execute_any_proc return boolean is
l_ut_owner varchar2(250) := ut_utils.ut_owner;
begin
return is_object_visible(l_ut_owner||'.ut_utils');
return is_object_visible(l_ut_owner||'.ut_utils') and sys_context('userenv','current_schema') != l_ut_owner;
end;

function is_object_visible(a_object_name varchar2) return boolean is
Expand Down
5 changes: 4 additions & 1 deletion source/core/ut_suite_manager.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,10 @@ create or replace package body ut_suite_manager is
a_owner_name varchar2
) return boolean is
begin
return sys_context( 'userenv', 'current_schema' ) = a_owner_name or ut_metadata.user_has_execute_any_proc() or ut_trigger_check.is_alive();
return sys_context( 'userenv', 'current_schema' ) = a_owner_name or ut_metadata.user_has_execute_any_proc()
or ( ut_trigger_check.is_alive()
and ut_annotation_cache_manager.get_cache_schema_info(a_owner_name, 'PACKAGE').full_refresh_time is not null
);
end;

procedure build_and_cache_suites(
Expand Down