Skip to content

Feature/update project documentation#230

Merged
Pazus merged 9 commits intoutPLSQL:developfrom
jgebal:feature/update_project_documentation
Mar 21, 2017
Merged

Feature/update project documentation#230
Pazus merged 9 commits intoutPLSQL:developfrom
jgebal:feature/update_project_documentation

Conversation

@jgebal
Copy link
Copy Markdown
Member

@jgebal jgebal commented Mar 13, 2017

No description provided.

jgebal added 5 commits March 12, 2017 16:07
…uded in html docs.

Updated project details
Updated mkdocs.yml - new pages added
Updated readme.md with new links
Added documentation for reporters and runnin-uni-tests
Added documentation for ut_run-script
@jgebal jgebal added this to the version3 milestone Mar 13, 2017
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 77.033% when pulling 7ec3477 on jgebal:feature/update_project_documentation into 0c57f09 on utPLSQL:develop.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 77.0% when pulling d2ffa0d on jgebal:feature/update_project_documentation into 9096940 on utPLSQL:develop.

Copy link
Copy Markdown
Member

@Pazus Pazus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add to the Installation guide a note that we create dbms_profiler tables if they dont already exists.

Comment thread docs/index.md Outdated

![3_steps](images/3_steps_to_run_utPLSQL.gif)

Check out the sections on [annotations](userguide/annotations.md) and [expectations](userguide/expectations.md) to see how to define your tests
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should provide lenks to other doc pages. Maybe womewhere in the beginning or at the end.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bit of a conflict here.
The html doc generated with mkdocs contains all the pages and links as a menu.
I wanted to avoid duplication on the index page with what is defined in mkdocs.yml already.
I just pointed references to the things that are mentioned on the index.
We could however have the contents section (similar to the one in readme.md file).
The trouble is the duplication of sources.
Maybe we should generate docs from main project page and the readme.md should be the main page?
Anyway. That could be done as a further cleanup.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- `be_greater_than`
- `be_greater_or_equal`
- `be_false`
# Matchers
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention that most matchers have shortcuts such as to_equal

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mention the shortcuts. We could add them as a separate section.
I think some shortcuts are not complete (not all data types have shortcuts to supported matchers). This is why they re not mentioned in the documentation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread docs/userguide/expectations.md Outdated

Usage:
```sql
ut.expect( a_actual {mulitple data-types} ).to_( be_between( a_lower_bound {mulitple data-types}, a_upper_bound {mulitple data-types}) );
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the whole page for it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread docs/userguide/expectations.md Outdated

Usage:
```sql
ut.expect( a_actual buulean ).to_( be_false() );
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type: boolean

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok


If a matcher evaluated to NULL, then both `to_` and `not_to` will cause the expectation to report failure.

Example:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think examples should be moved to the beginning of the page. To be honest this a_actual {mulitple data-types} is a bit tricky from the first glance. Examples at the beginning are going to help to treat such notaion.

Comment thread docs/userguide/reporters.md Outdated

#Teamcity reporter

[Teamcity](https://www.jetbrains.com/teamcity/) is a CI server by Jetbrains. The CI has it's own format of reporting that allows tracking of progress of a CI step/task as it executes.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it has the own format additionaly to the stadard ones like xUnit/jUnit

Comment thread docs/userguide/running-unit-tests.md Outdated
The main benefit of using this API is it's simplicity.
One-line call is enough to execute a set of tests form one or multiple schemes.

The **procedures** execute specified tests and produces outputs to DBMS_OUTPUT suing specified reporter
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "using"

Comment thread docs/userguide/running-unit-tests.md Outdated
end;
```

Execute all tests from all packages that are on the _COM.MY_ORG.MY_PROJECT_ suitepath.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to restructure the doc a bit. I believe we should treat suitepath as the prefered way to configure runs, so the examples should first demonstrate that approach. Calling by a package name is a convinient addition.

select * from table(ut.run('hr.test_apply_bonus', ut_xunit_reporter()));
```

# ut_runner.run
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should mention again that the easiest way to invoke ut_runner is to call it with ut_run.sql

Comment thread docs/userguide/expectations.md Outdated
@@ -14,66 +14,213 @@ Expectation is a set of the expected value(s), actual values(s) and the matcher(

Matcher is defining the comparison operation to be performed on expected and actual values.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can put the definition, matcher and example into a single table? I think it's going to be way shorter maybe even fit into a single screen

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 75.533% when pulling 6acb912 on jgebal:feature/update_project_documentation into 0e4c308 on utPLSQL:develop.

@Pazus Pazus merged commit 7a30f6c into utPLSQL:develop Mar 21, 2017
@Pazus Pazus removed the in progress label Mar 21, 2017
@jgebal jgebal deleted the feature/update_project_documentation branch March 22, 2017 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants