Skip to content

Feature/framework performance #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 3 commits into from
Mar 30, 2023
Merged

Feature/framework performance #1249

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28b6eaa
Small performance improvements to output buffer handling and some tests.
jgebal Feb 11, 2023
521fe47
Performance improvements in output buffer for reporters that only pro…
jgebal Mar 19, 2023
6c0b6e6
Fixes to new data-buffer implementation.
jgebal Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes to new data-buffer implementation.
  • Loading branch information
@jgebal
jgebal committed Mar 20, 2023
commit 6c0b6e681954c389ca2763edcc6c56a7d142b586
13 changes: 8 additions & 5 deletions source/core/output_buffers/ut_output_bulk_buffer.tpb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ create or replace type body ut_output_bulk_buffer is
select /*+ no_parallel */ self.output_id, self.last_write_message_id + rownum, t.column_value, a_item_type
from table(a_text_list) t
where t.column_value is not null or a_item_type is not null;
self.last_write_message_id := self.last_write_message_id + SQL%rowcount;
self.last_write_message_id := self.last_write_message_id + sql%rowcount;
commit;
end;

Expand Down Expand Up @@ -87,15 +87,16 @@ create or replace type body ut_output_bulk_buffer is
exit when l_data%notfound;
end loop;
close l_data;
self.remove_buffer_info();
end;

overriding member function get_lines_cursor(a_initial_timeout number := null, a_timeout_sec number := null) return sys_refcursor is
lc_init_wait_sec constant number := coalesce(a_initial_timeout, 30 );
lc_init_wait_sec constant number := coalesce(a_initial_timeout, 10 );
l_already_waited_sec number(10,2) := 0;
l_sleep_time number(2,1);
l_exists integer;
l_finished boolean := false;
l_data_produced boolean;
l_data_produced boolean := false;
l_producer_active boolean := false;
l_producer_started boolean := false;
l_producer_finished boolean := false;
Expand All @@ -115,11 +116,13 @@ create or replace type body ut_output_bulk_buffer is
l_producer_active := (self.get_lock_status() <> 0);
l_producer_started := (l_producer_active or l_data_produced ) or l_producer_started;
l_producer_finished := (l_producer_started and not l_producer_active) or l_producer_finished;

l_finished :=
self.timeout_producer_not_finished(l_producer_finished, l_already_waited_sec, a_timeout_sec)
or self.timeout_producer_not_started(l_producer_started, l_already_waited_sec, lc_init_wait_sec)
or l_producer_finished;

dbms_lock.sleep(l_sleep_time);
l_already_waited_sec := l_already_waited_sec + l_sleep_time;
end loop;

open l_results for
Expand Down Expand Up @@ -152,8 +155,8 @@ create or replace type body ut_output_bulk_buffer is
exit when l_data%notfound;
end loop;
close l_data;
return;
self.remove_buffer_info();
return;
end;

end;
Expand Down