Skip to content

Feature/nested context #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 8 commits into from
Nov 1, 2019
Merged

Feature/nested context #1013

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eebfba0
Added support for nested contexts.
jgebal Oct 23, 2019
c5f81eb
Fixing failing tests
jgebal Oct 23, 2019
837bd47
Merge remote-tracking branch 'origin/develop' into feature/nested_con…
jgebal Oct 23, 2019
e1dfd05
Updated documentation.
jgebal Oct 23, 2019
0070cf8
changed hard stop to "full stop/period"
jgebal Oct 23, 2019
8f0b267
Cleanup
jgebal Oct 23, 2019
2abd27e
Merge remote-tracking branch 'origin/develop' into feature/nested_con…
jgebal Oct 25, 2019
be39586
Added support for `--%name` annotation, to name the contexts.
jgebal Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing failing tests
  • Loading branch information
@jgebal
jgebal committed Oct 23, 2019
commit c5f81eb1b25729166f13182cdd508c4860cd6fcb
2 changes: 1 addition & 1 deletion source/core/ut_suite_builder.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ create or replace package body ut_suite_builder is

if l_end_context_pos is null then
a_suite.put_warning(
'Missing "--%endcontext" annotation for a "--%context" annotation. The end of package specification is effective end of context.'|| get_object_reference( a_suite, null, l_context_pos )
'Missing "--%endcontext" annotation for a "--%context" annotation. The end of package is considered end of context.'|| get_object_reference( a_suite, null, l_context_pos )
);
l_end_context_pos := a_annotations.by_line.last;
end if;
Expand Down
2 changes: 1 addition & 1 deletion test/ut3_tester/core/test_suite_builder.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ create or replace package body test_suite_builder is
l_actual := invoke_builder_for_annotations(l_annotations, 'SOME_PACKAGE');
--Assert
ut.expect(l_actual).to_be_like(
'%<WARNINGS><VARCHAR2>Missing &quot;--\%endcontext&quot; annotation for a &quot;--\%context&quot; annotation. The end of context considered be end of package.%at package &quot;UT3_TESTER.SOME_PACKAGE&quot;, line 4</VARCHAR2></WARNINGS>%'
'%<WARNINGS><VARCHAR2>Missing &quot;--\%endcontext&quot; annotation for a &quot;--\%context&quot; annotation. The end of package is considered end of context.%at package &quot;UT3_TESTER.SOME_PACKAGE&quot;, line 4</VARCHAR2></WARNINGS>%'
,'\'
);
ut.expect(l_actual).to_be_like(
Expand Down
2 changes: 1 addition & 1 deletion test/ut3_tester/core/test_suite_builder.pks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ create or replace package test_suite_builder is
--%test(Propagates beforeeach/aftereach to context)
procedure before_after_out_of_context;

--%test(Does not create context and gives warning when endcontext is missing)
--%test(Gives warning when endcontext is missing)
procedure context_without_endcontext;

--%test(Gives warning if --%endcontext is missing a preceding --%context)
Expand Down
2 changes: 1 addition & 1 deletion test/ut3_user/api/test_ut_run.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ Failures:%
select * bulk collect into l_results from table(ut3.ut.run('bad_annotations'));
l_actual := ut3_tester_helper.main_helper.table_to_clob(l_results);

ut.expect(l_actual).to_be_like('%Missing "--%endcontext" annotation for a "--%context" annotation. The end of context considered be end of package.%
ut.expect(l_actual).to_be_like('%Missing "--%endcontext" annotation for a "--%context" annotation. The end of package is considered end of context.%
%1 tests, 0 failed, 0 errored, 0 disabled, 1 warning(s)%');

end;
Expand Down