Skip to content

fix: manifest version don't warn on prerelease - #10554

Merged
olblak merged 2 commits into
updatecli:mainfrom
olblak:fix/version/matching
Sep 20, 2026
Merged

fix: manifest version don't warn on prerelease#10554
olblak merged 2 commits into
updatecli:mainfrom
olblak:fix/version/matching

Conversation

@olblak

@olblak olblak commented Sep 19, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.
  • I have tested this pull request manually with a custom Updatecli build and it works as expected.

Tradeoff

Potential improvement

Summary by CodeRabbit

  • Bug Fixes
    • Manifests requiring the current Updatecli version are now accepted as compatible.
    • Prerelease and build-metadata versions are compared against their corresponding release versions, improving compatibility when using release candidates or specially labeled builds.
    • Version compatibility checks continue to handle empty versions and invalid version formats consistently.

@olblak
fix: manifest version matching handle prerelease
32509a7 
Signed-off-by: Olblak <me@olblak.com>
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5021ff47-4828-4209-ad73-5da6a5936781

📥 Commits

Reviewing files that changed from the base of the PR and between c0e2fe6 and 32509a7.

📒 Files selected for processing (3)
  • pkg/core/config/main.go
  • pkg/core/version/main.go
  • pkg/core/version/main_test.go

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

Version comparison now uses the release line when binaries contain prerelease or build metadata. Manifest validation accepts equal current and required versions. Tests add named cases for these comparisons and improve failure reporting.

Changes

Version compatibility

Layer / File(s) Summary
Release-line comparison and validation
pkg/core/version/main.go, pkg/core/version/main_test.go, pkg/core/config/main.go		 IsGreaterThan compares versions without prerelease or build metadata. Tests cover matching, newer, older, and absent requirements. ValidateManifestCompatibility accepts equal versions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the test and checklist sections, but it omits the issue reference and provides no summary of the implemented changes. The Tradeoff and Potential improvement sections also rema… Add the relevant issue reference, describe the manifest version matching changes, and complete the Tradeoff and Potential improvement sections or state that none apply.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: preventing warnings for prerelease manifest versions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes the test and checklist sections, but it omits the issue reference and provides no summary of the implemented changes. The Tradeoff and Potential improvement sections also remain empty.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@olblak
olblak merged commit 026fd05 into updatecli:main Sep 20, 2026
8 of 9 checks passed
@olblak olblak added release Track issues related to releasing Updatecli bug Something isn't working labels Sep 20, 2026
@olblak
olblak deleted the fix/version/matching branch September 21, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working release Track issues related to releasing Updatecli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@olblak