Restore ability to use tempfile kwargs other than dir#40
Conversation
|
I see that the tox stylecheck fails. If you have any interest in this PR I'll fix it up to conform. |
|
lgtm. Please just type out the kwargs in the function signature though. if you could take care of the styling issues that would also be great, yeah. |
|
Would you like named parameters corresponding to both tempfile.mkstemp() and io.open(), or just tempfile.mkstemp()? As you mentioned in #38 removing kwargs entirely in favor of explicit options is nicer for API docs, and I tend to agree. |
|
So I would like the following params: |
The changes in untitaker#38 broke the ability to use prefix, suffix and bufsize arguments when creating the tempfile. This commit restores the ability.
|
I have updated |
|
released 1.3.0, have fun :) |
|
Awesome, thanks! This project has saved me from having to figure this all out myself :) |
The changes in #38 broke the ability to use prefix, suffix and bufsize arguments when creating the tempfile. This pull request restores the ability, and is intended to fix #39