chore(studio/frontend): normalize line endings to LF#6012
Open
danielhanchen wants to merge 2 commits into
Open
chore(studio/frontend): normalize line endings to LF#6012danielhanchen wants to merge 2 commits into
danielhanchen wants to merge 2 commits into
Conversation
45 source files under studio/frontend/ were committed with CRLF or mixed line endings while the rest of the repo and the JS/TS tooling assume LF. Add a scoped `studio/frontend/** text=auto eol=lf` rule to .gitattributes and run `git add --renormalize studio/frontend` so these files are stored with LF in the index. The rule is scoped to the frontend tree (not a repo-wide *.ts/*.tsx/... policy) so it cannot force LF on files elsewhere; text=auto leaves binary assets (logos, fonts) untouched. This commit is whitespace-only (CRLF -> LF) — no source content changed (verified with `git diff --ignore-cr-at-eol`). It is intentionally isolated so it can be listed in .git-blame-ignore-revs and skipped by reviewers and `git blame`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add .git-blame-ignore-revs listing the whitespace-only line-ending normalization commit so it doesn't pollute `git blame` output. GitHub applies this file automatically; locally run `git config blame.ignoreRevsFile .git-blame-ignore-revs`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request normalizes the line endings of the Studio frontend source files to LF. It updates .gitattributes to enforce this policy for the studio/frontend/ directory and adds the normalization commit to .git-blame-ignore-revs to prevent obscuring git blame history. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
45 source files under
studio/frontend/were committed with CRLF (10 files) or mixed (35 files) line endings, while the rest of the repo and the JS/TS tooling assume LF. This normalizes them to LF..gitattributes:*.ts/*.tsx/… rules) so it can't force LF on files elsewhere.text=autolets Git auto-detect and leave binary assets (logos, fonts) untouched while text files are stored as LF.git add --renormalize studio/frontendto rewrite the affected blobs..git-blame-ignore-revslisting the normalization commit sogit blameskips it (GitHub applies this automatically).Why
Pure diff-hygiene / consistency. There's no functional breakage today — JS/TS tooling tolerates CRLF — but mixed endings produce noisy diffs and confuse
git blame/editors. This complements the existing*.pyand*.shLF rules.Reviewing
The first commit is whitespace-only (CRLF → LF) — no source content changed. Verified with:
i.e. once CR-at-EOL is ignored, the only real change is the
.gitattributesrule. Review with whitespace hidden (append?w=1to the Files-changed URL). The normalization commit is isolated and listed in.git-blame-ignore-revs.git ls-files --eol studio/frontendafter the change:Scope
Standalone PR. Independent of #5997 (the
*.shEOL rule, already onmain) and #5940 (installer). No logic changes.