feat: expose AST handles on MacroContext#151
Merged
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
astfield toMacroContextthat exposes the AST handles for the current macro invocation:ast.call— theCallExpressionnode for this macro invocation. Forawait fn()macros the innerCallExpressionis returned (not the wrappingAwaitExpression). For tagged-template macros, a synthesizedCallExpressionis provided whoseloc/start/endmatch the originalTaggedTemplateExpression.ast.program— theProgramAST of the enclosing file.Also:
MacroContextsurface) in the README, with a$callsiteexample.tests/fixtures/ast.js+tests/fixtures/macros/ast.ts) and a type-level test intests/define.test.ts.Why
Closes #132. Macro authors previously had no way to get callsite-aware info (line/column, raw call source, surrounding program) without resorting to runtime stack walks or re-parsing the file. Exposing the already-available Babel nodes is essentially free and unlocks patterns like
$callsite(), conditional rewrites, and lightweight code analysis at compile time.Test notes
tests/__snapshots__/fixtures.test.ts.snapcovers theast.jsfixture (line/column/calleeName/callSource/programType all round-trip correctly).tests/define.test.tsensurethis.ast.call.typeandthis.ast.program.typeare correctly narrowed.Follow-ups
unpluginContextremains marked experimental;astis intentionally a stable, minimal surface (call+program) so we can extend it later without breaking changes.