fix(textbox): subpixel gaps between adjacent selected characters#22962
Merged
ramezgerges merged 5 commits intounoplatform:masterfrom Apr 14, 2026
Merged
fix(textbox): subpixel gaps between adjacent selected characters#22962ramezgerges merged 5 commits intounoplatform:masterfrom
ramezgerges merged 5 commits intounoplatform:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets Skia text rendering for UnicodeText to reduce visible seams/gaps between adjacent highlighted/selected character clusters by changing how background rectangles are pixel-aligned.
Changes:
- Adjusts highlight background rectangle X rounding logic (switching from
RoundtoFloorand extending right edge). - Adds
Console.WriteLinecalls at the start/end ofDraw(these should not ship in rendering code).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22962/wasm-skia-net9/index.html |
Contributor
|
The build 205461 found UI Test snapshots differences: Details
|
f1502dc to
02b39e8
Compare
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22962/wasm-skia-net9/index.html |
Contributor
|
The build 205476 found UI Test snapshots differences: Details
|
Contributor
|
|
Xiaoy312
approved these changes
Apr 4, 2026
Contributor
Xiaoy312
left a comment
There was a problem hiding this comment.
<3, that was so annoying!
Contributor
|
The build 205476 found UI Test snapshots differences: Details
|
MartinZikmund
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
The build 206090 found UI Test snapshots differences: Details
|
Contributor
|
The build 206090 found UI Test snapshots differences: Details
|
Contributor
|
|
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22962/wasm-skia-net9/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️