feat: Make spell-checking opt-in via SpellChecking UnoFeature#22937
Merged
ramezgerges merged 2 commits intounoplatform:masterfrom Apr 14, 2026
Merged
feat: Make spell-checking opt-in via SpellChecking UnoFeature#22937ramezgerges merged 2 commits intounoplatform:masterfrom
ramezgerges merged 2 commits intounoplatform:masterfrom
Conversation
Spell-checking was automatically included for all desktop/Skia apps, adding the Uno.WinUI.SpellChecking dependency by default. This changes it to opt-in via `<UnoFeatures>SpellChecking;</UnoFeatures>` to reduce default binary size for apps that don't use spell-checking. - Add SpellChecking enum value to UnoFeature (Core area) - Change MSBuild condition to require SpellChecking UnoFeature while retaining the Skia platform guard - Lower missing service log from Error to Warning (now expected state) - Add SpellChecking row to UnoFeatures documentation table - Create spell-checking docs page with custom dictionary guidance Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Makes Uno’s Skia spell-checking support opt-in by introducing a dedicated SpellChecking UnoFeature, gating the implicit Uno.WinUI.SpellChecking package reference behind it, and documenting how to enable/configure dictionaries.
Changes:
- Add
UnoFeature.SpellCheckingand document it in the Uno.Sdk features list. - Gate the
Uno.WinUI.SpellCheckingimplicit package behindUnoFeaturescontainingSpellChecking(and only for Skia-rendering targets). - Add a new spell-checking feature doc page and adjust the runtime log severity when no
ISpellCheckingServiceis present.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs | Downgrades missing ISpellCheckingService log severity from error to warning. |
| src/Uno.Sdk/UnoFeature.cs | Adds new SpellChecking UnoFeature enum value. |
| src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets | Makes Uno.WinUI.SpellChecking implicit package reference opt-in via UnoFeatures. |
| doc/articles/features/using-the-uno-sdk.md | Documents the new SpellChecking feature in the supported features table. |
| doc/articles/features/spellchecking.md | Adds a new documentation page describing how to enable spell-checking and load custom dictionaries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22937/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22937/docs/index.html |
Contributor
|
The build 204916 found UI Test snapshots differences: Details
|
Contributor
|
The build 204916 found UI Test snapshots differences: Details
|
Member
|
@ramezgerges Also make sure to add the feature to |
Member
|
@ramezgerges also the Copilot comments are quite relevant, should be addressed |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22937/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22937/wasm-skia-net9/index.html |
MartinZikmund
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #22661
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️