Conversation
6f76bb7 to
79b8559
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new documentation page describing Uno Platform Native AOT support and links it into the docs table of contents so it’s discoverable alongside other performance/publishing topics.
Changes:
- Add a new
Native AOT Supportdocumentation page underdoc/articles/features/. - Add a TOC entry pointing to the new page.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| doc/articles/toc.yml | Adds a navigation entry for the new Native AOT documentation page. |
| doc/articles/features/native-aot.md | Introduces a new Native AOT guidance page (overview, CLI publish guidance, limitations, and mitigation tips). |
Comments suppressed due to low confidence (1)
doc/articles/features/native-aot.md:300
- The content after the horizontal rule reads like a draft/summary block and is not formatted as structured documentation (lists are plain lines, no headings, and it duplicates earlier points). Please either remove it or convert it into proper sections with markdown lists/headings so it renders correctly and stays maintainable.
[uno-chefs]: https://github.com/unoplatform/uno.chefs/commit/06f4f804
[uno-gallery]: https://github.com/unoplatform/Uno.Gallery/commit/b8544a43da13b59ab4355af6dfcb27c9047fffbb
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
| | **Sample** | **Environment** | **Runtime** | **Publish Size** | **Startup Times (s)** | | ||
| | ----------------------------------------------------- | ----------------- | ----------- | ------------------------: | ------------------------: | | ||
| | [Uno.Gallery][uno-gallery] with Uno.Sdk 6.6.0-dev.127 | iOS, .NET 10 | MonoVM | 84M | 2.241s | | ||
| | [Uno.Gallery][uno-gallery] with Uno.Sdk 6.6.0-dev.127 | iOS, .NET 10 | NativeAOT | 65M <BR> (77% MonoVM) | 0.978s <BR> (44% MonoVM) | | ||
| | [Uno.Chefs][uno-chefs] with Uno.Sdk 6.6.0-dev.127 | Linux, .NET 10 | CoreCLR | 450M | 2.58s | | ||
| | [Uno.Chefs][uno-chefs] with Uno.Sdk 6.6.0-dev.127 | Linux, .NET 10 | NativeAOT | 533M <BR> (118% CoreCLR) | 1.06s <BR> (41% CoreCLR) | | ||
| | [Uno.Chefs][uno-chefs] with Uno.Sdk 6.6.0-dev.127 | macOS, .NET 10 | CoreCLR | 457M | 3.805s | | ||
| | [Uno.Chefs][uno-chefs] with Uno.Sdk 6.6.0-dev.127 | macOS, .NET 10 | NativeAOT | 645M <BR> (140% CoreCLR) | 1.162s <BR> (31% CoreCLR) | | ||
| | [Uno.Chefs][uno-chefs] with Uno.Sdk 6.6.0-dev.127 | Windows, .NET 10 | CoreCLR | 457M | 2.408s | | ||
| | [Uno.Chefs][uno-chefs] with Uno.Sdk 6.6.0-dev.127 | Windows, .NET 10 | NativeAOT | 624M <BR> (137% CoreCLR) | 0.737s <BR> (31% CoreCLR) | |
There was a problem hiding this comment.
Do we want those dev versions for public docs ? or just a placeholder for now until we have results with stable next version released ?
There was a problem hiding this comment.
@agneszitte: Mostly a placeholder. There's a bit of a "circular dependency" here, as a stable 6.6.x doesn't exist yet -- nor do I know when it will exist -- but we want something meaningful.
Assuming that this table is the "something meaningful" we want to present. Maybe we want something different?
There was a problem hiding this comment.
@jonpryor Let's keep it for now until we have the rest of the documentation done, and then we can review with the Team
79b8559 to
6e6eefc
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22935/docs/index.html |
6e6eefc to
b3fd173
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b3fd173 to
1767348
Compare
1767348 to
19e502f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22935/docs/index.html |
19e502f to
7a5a96d
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22935/docs/index.html |
- Add missing `---` terminator after Prerequisites tab group (line 39) - Add missing `---` terminator after Log Everything tab group (line 203) - Fix [!NOTE] admonitions to use blockquote syntax (`> [!NOTE]`)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
I wonder if two `[!NOTE]` blocks in a row is valid…
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22935/docs/index.html |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22935/docs/index.html |
57bd4c7 to
efb23cd
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22935/docs/index.html |
efb23cd to
f58e03a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22935/docs/index.html |
Context: https://github.com/unoplatform/uno-private/issues/1440
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️