`MenuFlyout` update, `Flyout` support for accelerators, `SplitMenuFlyoutItem` by MartinZikmund · Pull Request #17292 · unoplatform/uno

MartinZikmund · 2024-06-25T11:45:46Z

GitHub Issue (If applicable): closes #19407, closes #22094, closes #22956

PR Type

What kind of change does this PR introduce?

Bugfix
Feature

What is the current behavior?

MenuFlyout code is not up to date with WinUI
Keyboard accelerators don't work properly with MenuFlyout and nested menus

What is the new behavior?

Both supported

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops · 2024-06-25T12:09:05Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17292/index.html

unodevops · 2024-06-25T12:20:30Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/index.html

unodevops · 2024-08-05T17:44:35Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/index.html

unodevops · 2024-08-05T18:23:37Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17292/index.html

unodevops · 2024-10-17T14:20:19Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/index.html

jeromelaban · 2024-11-27T14:57:56Z

/azp run

azure-pipelines · 2024-11-27T14:58:24Z

Azure Pipelines successfully started running 2 pipeline(s).

unodevops · 2024-11-27T16:22:08Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/index.html

unodevops · 2024-12-26T18:10:40Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/index.html

github-actions · 2025-04-05T02:05:59Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

unodevops · 2025-05-01T07:42:31Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/index.html

unodevops · 2025-05-01T08:26:59Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/index.html

unodevops · 2025-05-06T14:22:44Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/docs/index.html

unodevops · 2025-05-06T15:13:48Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/docs/index.html

unodevops · 2025-05-06T15:22:33Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17292/wasm-native-net9/index.html

unodevops · 2025-05-06T15:40:35Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17292/docs/index.html

Replace fixed Task.Delay(100) with condition-based WaitFor in both EnsureFocusAsync overloads. The 100 ms per-attempt window was too tight on cold WASM runtimes, causing KeyboardAcceleratorTests to fail on first try but pass on retry.

…ithLongItems The test asserted ScrollableHeight > 0 on the MenuFlyoutPresenterScrollViewer, but on SkiaWasm and SkiaIOS the XamlRoot visible bounds are unconstrained, so all 30 items fit and no scrollbar is produced. Apply an explicit MaxHeight via MenuFlyoutPresenterStyle to make the assertion deterministic across platforms until #23018 adds real window size override support to the test harness.

Copilot

Pull request overview

Copilot reviewed 121 out of 126 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

unodevops · 2026-04-14T04:45:52Z

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17292/wasm-skia-net9/index.html

unodevops · 2026-04-14T10:20:31Z

⚠️⚠️ The build 207126 has failed on Uno.UI - CI.

github-actions Bot added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform labels Jun 25, 2024

MartinZikmund force-pushed the dev/mazi/keyboard-accelerator-flyout branch from 10bac4e to bf692ed Compare August 5, 2024 15:52

MartinZikmund force-pushed the dev/mazi/keyboard-accelerator-flyout branch from bf692ed to c66bc5e Compare October 17, 2024 12:38

jeromelaban marked this pull request as draft November 27, 2024 14:58

MartinZikmund force-pushed the dev/mazi/keyboard-accelerator-flyout branch from c66bc5e to 0e572dd Compare December 26, 2024 17:32

MartinZikmund mentioned this pull request Dec 26, 2024

feat: MenuFlyout support for keyboard accelerators #17228

Closed

6 tasks

MartinZikmund self-assigned this Dec 26, 2024

github-actions Bot added the stale This item has been marked as stale and will be closed if there is no activity. label Apr 5, 2025

MartinZikmund removed the stale This item has been marked as stale and will be closed if there is no activity. label Apr 6, 2025

MartinZikmund force-pushed the dev/mazi/keyboard-accelerator-flyout branch from 87a0390 to c22f6b7 Compare May 1, 2025 07:18

github-actions Bot removed the platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform label May 1, 2025

MartinZikmund force-pushed the dev/mazi/keyboard-accelerator-flyout branch from 4cf14cc to 4947939 Compare May 6, 2025 13:32

MartinZikmund added 24 commits April 14, 2026 06:24

fix: Leak issues

52a28f4

fix: ContextFlyout parenting

351d6eb

test: SplitMenuFlyoutItem sample page

e4a7558

test: SplitMenuFlyoutItem runtime tests

bfc0387

feat: SplitMenuFlyoutItem

22491ac

chore: Address build issues

3479068

chore: Address comments

f32a043

chore: Adjust diffignore

cb8b16f

chore: Adjust for failing tests

dc3f2c0

chore: Disable new tests on native targets

7513247

chore: Fallback

85483be

chore: Disable on WinAppSDK

97deb3f

fix: Visual tree discrepancy

beb2ca0

chore: Disable sample page on WinUI

4df15de

chore: Adjust for reference build

b301ee4

test: Improve reliability on WASM

3abb9fb

chore: Disable KeyboardAcceleratorTests on native mobile targets

ce099c7

test: Override visible bounds for large MenuFlyout positioning test

8e425c7

chore: XamlStyler

92e0ded

chore: Adjust test

87bb8ad

test: Disable failing test on Skia iOS

fc5753e

chore: Disable test on Skia WASM and iOS

560018e

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread src/Uno.UI/UI/Xaml/EnterParams.cs

morning4coffe-dev approved these changes Apr 14, 2026

View reviewed changes

MartinZikmund mentioned this pull request Apr 21, 2026

MenuFlyout and ToggleMenuFlyoutItem support for Keyboard Accelerators #17133

Closed

jonpryor mentioned this pull request Apr 21, 2026

chore: fix Build Android+NativeAOT Skia Head step #23104

Open

5 tasks

Conversation

MartinZikmund commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

Uh oh!

unodevops commented Jun 25, 2024

Uh oh!

unodevops commented Jun 25, 2024

Uh oh!

unodevops commented Aug 5, 2024

Uh oh!

unodevops commented Aug 5, 2024

Uh oh!

unodevops commented Oct 17, 2024

Uh oh!

jeromelaban commented Nov 27, 2024

Uh oh!

azure-pipelines Bot commented Nov 27, 2024

Uh oh!

unodevops commented Nov 27, 2024

Uh oh!

unodevops commented Dec 26, 2024

Uh oh!

github-actions Bot commented Apr 5, 2025

Uh oh!

unodevops commented May 1, 2025

Uh oh!

unodevops commented May 1, 2025

Uh oh!

unodevops commented May 6, 2025

Uh oh!

unodevops commented May 6, 2025

Uh oh!

unodevops commented May 6, 2025

Uh oh!

unodevops commented May 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

unodevops commented Apr 14, 2026

Uh oh!

unodevops commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MartinZikmund commented Jun 25, 2024 •

edited

Loading