fix: optimize shortcuts ordering#4566
Open
jrr997 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr tries to fix #4379
The sorting of shortcuts depends on the order of their tokens in the rules array. For example, with
'btn-notworking': 'bg-gray-200 hover:bg-gray-300 active:bg-blue active:scale-95'The index of
active:scale-95in the rules array comes beforeactive:bg-blue. Meanwhile, the sorting ofbtn-notworking:activetakes the minimum value (the index ofactive:scale-95), which results in the final generated style having 'btn-notworking:active' placed before 'btn-notworking:hover'.I think it would be more reasonable for the sorting of shortcuts to be based on the maximum index in the rules array.