Repository navigation
refactor: upgrade to chokidar to v4 - #596
Merged
Merged
Conversation
Deploying unstorage with
|
| Latest commit: |
0f8f763
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d7b38384.unstorage.pages.dev |
| Branch Preview URL: | https://feat-chokidar-v4.unstorage.pages.dev |
Deploying unstorage with
|
| Latest commit: |
391070f
|
| Status: | ⚡️ Build in progress... |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Member
|
Looks good to me! |
danielroe
approved these changes
Feb 21, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Member
Author
|
(updated impl to reuse same anymatch we use for filtering) |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We initially upgraded to chokidar v4 (#489) then reverted back to #502 as a hotfix (see relevant issues)
Stability and ecosystem adoption seem now much better. The only remaining part is that chokidar v4 dropped glob support.
This PR updates to use same
anymatchmatcher we use for listing key filtering, to also apply towatchOptions.ignoredFollowup #597
If users already provided customignoreoption, it would be breaking change: Added via a lightweight polyfill with patheDefault ignores["**/node_modules/**", "**/.git/**"]added using simply regex matcher