Skip to content

README update - #489

Merged
liquid-8 merged 2 commits into
uniswap-python:dev/v4-finfrom
liquid-8:v4_UF_grant
Oct 14, 2026
Merged

README update#489
liquid-8 merged 2 commits into
uniswap-python:dev/v4-finfrom
liquid-8:v4_UF_grant

Conversation

@liquid-8

@liquid-8 liquid-8 commented Oct 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@liquid-8
liquid-8 merged commit 6711d56 into uniswap-python:dev/v4-fin Oct 14, 2026
5 checks passed
@greptile-apps

greptile-apps Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[High impact] Changes CI environment configuration for blockchain provider.

The PR appears safe to merge, with a non-blocking correction needed in the V1 release note.

Findings

  1. P2 V1 removal is misstated ▶

Summary

This PR adds the 0.9.0 changelog and changes the mainnet RPC endpoint used by CI.

  • Mainnet tests now use the drpc.org endpoint.
  • The README now lists the changes for version 0.9.0.

Reviews (1) · Last reviewed commit: "README update" · Reviewed by Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Oct 14, 2026
View reviewed changes
Comment thread README.md
* Added: Async versions of Uniswap V2-V4
* Added: V2 and V3 custom routes (untested)
* Added: Async pool cache service for Uniswap V4
* Removed: V1 support

@greptile-apps greptile-apps Bot Oct 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 V1 removal is misstated

The changelog says V1 support was removed, but Uniswap still defaults to version=1, accepts it, and loads V1 contracts. AsyncUniswap also accepts V1. This may lead readers to plan an unnecessary migration. If only V1 testing or maintenance ended, say that instead; otherwise remove this entry until the public clients match it.

Knowledge Base Used: Uniswap client SDK

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@codecov

codecov Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.20%. Comparing base (4a45cf9) to head (36b834f).
⚠️ Report is 2 commits behind head on dev/v4-fin.

Additional details and impacted files 
@@              Coverage Diff               @@
##           dev/v4-fin     #489      +/-   ##
==============================================
- Coverage       70.48%   70.20%   -0.29%     
==============================================
  Files              14       14              
  Lines            4282     4282              
==============================================
- Hits             3018     3006      -12     
- Misses           1264     1276      +12

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@liquid-8