Skip to content

test(v4): poll Anvil startup instead of a fixed sleep #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 2 commits into from
Oct 13, 2026
Merged

test(v4): poll Anvil startup instead of a fixed sleep #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baff47d
test(v4): poll Anvil startup instead of a fixed sleep
TimeToBuildBob Oct 13, 2026
44371ed
fix(tests): reap timed-out Anvil and use monotonic deadlines
TimeToBuildBob Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions tests/test_uniswap4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import logging
import os
import shutil
import socket
import subprocess
import time
from contextlib import contextmanager
from dataclasses import astuple, dataclass
from time import sleep
from typing import Generator, List, Optional

import pytest
Expand Down Expand Up @@ -118,7 +119,23 @@ def anvil() -> Generator[AnvilInstance, None, None]:
# Address #1 when anvil is run with `--wallet.seed test`, it starts with 1000 ETH
eth_address = "0xa0Ee7A142d267C1f36714E4a8F75612F20a79720"
eth_privkey = "0x2a871d0798f97d79848a013d4936a73bf4cc922c825d33c1cf7073dff6d409c6"
sleep(3)
# Poll until Anvil accepts connections. Fail immediately if the process
# exits (for example a genesis failure), rather than waiting out the deadline.
deadline = time.monotonic() + 60
while time.monotonic() < deadline:
if p.poll() is not None:
raise RuntimeError(
f"Anvil exited before listening on port {port} (code {p.returncode})"
)
try:
with socket.create_connection(("127.0.0.1", port), timeout=1):
break
except OSError:
time.sleep(0.5)
else:
p.kill()
p.wait()
raise RuntimeError(f"Anvil did not start on port {port} within 60s")
Comment thread
TimeToBuildBob marked this conversation as resolved.
yield AnvilInstance(f"http://127.0.0.1:{port}", eth_address, eth_privkey)
p.kill()
p.wait()
Expand Down
21 changes: 19 additions & 2 deletions tests/test_v4_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@

import os
import shutil
import socket
import subprocess
import time
from dataclasses import dataclass
from time import sleep
from typing import Generator

import pytest
Expand Down Expand Up @@ -98,7 +99,23 @@ def anvil() -> Generator[AnvilInstance, None, None]:
# Anvil test account #2 (1000 ETH pre-funded)
eth_address = "0x3C44CdDdB6a900fa2b585dd299e03d12FA4293BC"
eth_privkey = "0x5de4111afa1a4b94908f83103eb1f1706367c2e68ca870fc3fb9a804cdab365a"
sleep(3)
# Poll until Anvil accepts connections. Fail immediately if the process
# exits (for example a genesis failure), rather than waiting out the deadline.
deadline = time.monotonic() + 60
while time.monotonic() < deadline:
if p.poll() is not None:
raise RuntimeError(
f"Anvil exited before listening on port {port} (code {p.returncode})"
)
try:
with socket.create_connection(("127.0.0.1", port), timeout=1):
break
except OSError:
time.sleep(0.5)
else:
p.kill()
p.wait()
raise RuntimeError(f"Anvil did not start on port {port} within 60s")
yield AnvilInstance(f"http://127.0.0.1:{port}", eth_address, eth_privkey)
p.kill()
p.wait()
Expand Down
Loading