D1 UF grant by liquid-8 · Pull Request #485 · uniswap-python/uniswap-python

liquid-8 · 2026-10-11T22:40:25Z

No description provided.

This reverts commit fa75632.

This reverts commit de63ce4.

fin

Removed unused imports and cleaned up code formatting.

Pool manager contract ABI

Deleted due to naming fix

Naming fix

Liquidity pools list management class added, UniswapV4 improvements.

refactor

refactoring+bug fixes

moved to util

moved to types

moved to constants

Add router v2.1.1 support; add X Layer, Tempo, Robinhood networks support; remove Blast and testnets support.

Also minor improvements and docstring clarification.

This PR upgrades codebase to the latest Web3 version, adds async clients and v3 multi-hop trades, and adds async tests. Python callers can use async clients for Uniswap requests. v3 quotes and trades can follow multi-pool routes. The library and its tooling now use Python 3.12 and Web3.py 8. Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

codecov · 2026-10-11T22:41:26Z

Codecov Report

❌ Patch coverage is 71.18943% with 327 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.21%. Comparing base (aa2c09a) to head (aad7a59).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
uniswap/asyncuniswap.py	71.69%	229 Missing ⚠️
uniswap/util.py	67.42%	43 Missing ⚠️
uniswap/uniswap.py	68.54%	39 Missing ⚠️
uniswap/uniswap4.py	73.46%	13 Missing ⚠️
uniswap/decorators.py	33.33%	2 Missing ⚠️
uniswap/tokens.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   73.26%   70.21%   -3.05%     
==========================================
  Files          12       14       +2     
  Lines        2319     4284    +1965     
==========================================
+ Hits         1699     3008    +1309     
- Misses        620     1276     +656

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

greptile-apps · 2026-10-11T22:49:40Z

Confidence Score: 0/5

[High impact] Adds Uniswap v4 support and updates build tooling.

The PR is not ready to merge because previously reported trade, provider, nonce, and async failures remain.

Findings

Existing token trades revert ▶
Native ETH routes fail ▶
Async clients use another provider ▶
Rejected sends block later transactions ▶
Concurrent swaps share a nonce ▶
Batch permits cannot be sent ▶
Fractional cancellation fees are lost ▶
Async trade setup doesn't run ▶
Pool creation ends with error ▶
Integer salts cannot be encoded ▶
Pool-discovery example fails ▶
v3 liquidity example fails ▶
Exact-output route instructions are reversed ▶
Mint example exceeds its budget ▶
Mint example lacks token approval ▶
Token lookup runs too early ▶

Summary

This PR adds Uniswap v4 clients, async clients, custom routes, pool discovery, and examples. It also updates dependencies and moves fork tests to Anvil.

Callers can quote trades and manage liquidity with Uniswap v4.
Async callers can use Uniswap clients without blocking their event loop.
Callers can find and reuse pools discovered from v4 events.
V2 and v3 callers can pass custom routes for multi-hop trades.
The project now builds, tests, and documents the newer client setup.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Caller[Python caller] --> Client[Sync or async v4 client]
  Client --> Quoter[Quoter: trade estimates]
  Client --> StateView[StateView: pool state]
  Client --> Router[Universal Router: swaps]
  Client --> PositionManager[PositionManager: liquidity]
  Router --> PoolManager[PoolManager]
  PositionManager --> PoolManager
  Discovery[Pool discovery] --> Events[PoolManager Initialize events]

_{Reviews (3) · Last reviewed commit: "README update (#489)" · Reviewed by Greptile}

greptile-apps · 2026-10-11T22:49:44Z

+    tick_lower: int
+    tick_upper: int
+    liquidity_delta: int
+    salt: int


Integer salts cannot be encoded

ModifyLiquidityParams.salt is declared as an int, but modifyLiquidity requires bytes32. Both wrappers pass the value through unchanged, so callers following the new type definition cannot encode the call. Use a 32-byte value or explicitly convert the integer before passing it.

Suggested change

salt: int

salt: bytes

greptile-apps · 2026-10-11T22:49:44Z

+    pools = V4pools(w3)
+
+    # Scan the chain (slow on first run — save to disk for reuse)
+    pools.fetch_poolkey_data(chunk_size=2000)


Pool-discovery example fails

The example omits the required first_block argument. Copying it raises TypeError before scanning any pools. Supply a starting block, such as the mainnet deployment block used by the tests.

Suggested change

pools.fetch_poolkey_data(chunk_size=2000)

pools.fetch_poolkey_data(first_block=21688329, chunk_size=2000)

greptile-apps · 2026-10-11T22:49:44Z

+    ONE_ETH = 10**18
+
+    # Get the pool contract instance
+    pool = uni.get_pool_instance(ETH, USDC, fee=500)


v3 liquidity example fails

get_pool_instance passes the zero ETH address directly to getPool, but v3 pools use WETH. The later mint_liquidity call also uses amount0 and amount1 instead of the accepted amount_0 and amount_1. Use WETH, assign amounts in the pool's token order, and correct the keyword names so users can run this example.

greptile-apps · 2026-10-11T22:49:44Z

+        """
+        :param token_exact: The token for which the qty parameter is specified, either the input or output token depending on the quote type.
+        :param qty: The amount of the token_exact to be swapped. For an exact output quote, this is the amount of output token desired.
+        :param route: The list of PoolKeys representing the path of the swap in reverse order, starting with the pool containing the output token and ending with the pool containing the input token.


Exact-output route instructions are reversed

The docstrings tell callers to supply pools in reverse order, but encode_path_keys_output expects input-to-output order and reverses the list itself. The tests use input-to-output order. Correct the exact-output docstrings in both v4 clients so users do not build routes through the wrong pools and get failed quotes or reverted swaps.

greptile-apps · 2026-10-14T01:34:38Z

+        event_logs = await self.factory_contract.events.PoolCreated().process_receipt(
+            receipt
+        )


Pool creation ends with error

AsyncUniswap.create_pool_instance awaits process_receipt, which reads an already-fetched receipt and returns the decoded events directly. After a pool is successfully created, this raises TypeError instead of returning its contract. Remove this await; keep the waits for sending the transaction and receiving its receipt.

Suggested change

event_logs = await self.factory_contract.events.PoolCreated().process_receipt(

receipt

)

event_logs = self.factory_contract.events.PoolCreated().process_receipt(

receipt

)

greptile-apps · 2026-10-14T01:34:38Z

+        liquidity=10**18,        # amount of liquidity to provide
+        amount0=ONE_ETH // 10,   # max ETH to spend
+        amount1=340 * 10**6,     # max USDC to spend


Mint example exceeds its budget

The example requests liquidity=10**18 while allowing only 0.1 ETH and 340 USDC. At the preceding example's price of 3400 USDC per ETH, this full-range position needs roughly 17,150 ETH and 58 million USDC, so the mint reverts. Calculate liquidity from the amounts, current price, and tick bounds using get_liquidity_for_amounts_by_ticks.

greptile-apps · 2026-10-14T01:34:38Z

+
+    ONE_ETH = 10**18
+
+    tx = uni.mint_position(


Mint example lacks token approval

The example never approves USDC for the PositionManager. mint_position does not add that approval, so a fresh wallet cannot pay the USDC needed for this position. Show approve(USDC, approve_position_manager=True) and wait for its receipt before minting.

Suggested change

tx = uni.mint_position(

approval_tx = uni.approve(USDC, approve_position_manager=True)

approval_receipt = uni.w3.eth.wait_for_transaction_receipt(approval_tx)

assert approval_receipt["status"]

tx = uni.mint_position(

greptile-apps · 2026-10-14T01:34:38Z

+    # Retrieve the ERC-721 token ID(s) minted by this transaction
+    token_ids = uni.get_minted_token_id(tx.hex())
+    token_id = token_ids[0]


Token lookup runs too early

The example calls get_minted_token_id immediately after broadcasting the mint. That helper uses get_transaction_receipt, not a receipt wait, so a normal pending transaction makes the lookup fail. Wait for the mint receipt and check its status before reading the token IDs.

Suggested change

# Retrieve the ERC-721 token ID(s) minted by this transaction

token_ids = uni.get_minted_token_id(tx.hex())

token_id = token_ids[0]

# Retrieve the ERC-721 token ID(s) minted by this transaction

receipt = uni.w3.eth.wait_for_transaction_receipt(tx)

assert receipt["status"]

token_ids = uni.get_minted_token_id(tx.hex())

token_id = token_ids[0]

* test: switch mainnet RPC in CI tests * README update

liquid-8 · 2026-10-14T09:04:51Z

@greptile-apps please review again considering convos in 4a45cf9 and ab467cd

ErikBjare · 2026-10-14T09:53:45Z

@liquid-8 Weird that you are targeting the stale/old v4-fin branch, if you target/work against master (or a branch more recently off master) you won't have all these risky conflicts.

liquid-8 · 2026-10-14T10:07:57Z

@liquid-8 Weird that you are targeting the stale/old v4-fin branch, if you target/work against master (or a branch more recently off master) you won't have all these risky conflicts.

Unfortunately not
Cant recall why that could happen.

What is really weird is why a review bot finds issues already resolved and ignores direct mentions to related convos. The current report has nothing in common with the state of affairs. I mean, if that were true, how could all tests be green?

* test: switch mainnet RPC in CI tests * README update * async_uniswap fixture fix

ErikBjare · 2026-10-14T14:56:27Z

@liquid-8 Most likely because you are working with the stale v4-fin branch which was squash merged as 4c42f1f

If you created a clean branch and PR, it wouldn't get confused about the 244 commits here of which the ancestors to your changes are not on master (squashed). That's kinda what I'm saying.

@TimeToBuildBob Demonstrate what I mean by making a clean PR with these changes targeting master.

TimeToBuildBob · 2026-10-14T15:03:45Z

Done — opened #491 as the clean branch Erik described.

It takes the full diff between master and dev/v4-fin HEAD and applies it as a single commit on top of current master, so reviewers see exactly what's new without the 244-commit squash-ancestry noise.

@liquid-8 for future PRs: branch off master directly (not from dev/v4-fin) and your changes will show up cleanly.

ErikBjare · 2026-10-14T17:22:16Z

Changes merged as part of #491

liquid-8 and others added 30 commits June 27, 2023 22:22

v4 support pre-alpha

de63ce4

v4 support pre-alpha

fa75632

Revert "v4 support pre-alpha"

0f0a189

This reverts commit fa75632.

Revert "v4 support pre-alpha"

d9b28e8

This reverts commit de63ce4.

Merge branch 'uniswap-python:master' into master

f1918d6

Merge branch 'uniswap-python:master' into master

f6b973b

Update __init__.py

18fad99

Merge pull request #417 from liquid-8/master

b84f0bc

fin

Add files via upload

2397805

Add Uniswap4 to module exports

6a113d5

Delete uniswap/uniswap-v4 directory

e0823f8

Add files via upload

441df01

Refactor uniswap4.py by removing unused imports

019704a

Removed unused imports and cleaned up code formatting.

Add files via upload

74e72b4

Pool manager contract ABI

Delete uniswap/configs/evmuniV4_permit2.ini

e33e9d2

Deleted due to naming fix

Delete uniswap/configs/evmuniV4_chains.ini

f7d8274

Deleted due to naming fix

Delete uniswap/configs/evmuniV4_quoter.ini

d7387a2

Deleted due to naming fix

Delete uniswap/configs/evmuniV4_router.ini

b21f2ee

Deleted due to naming fix

Delete uniswap/configs/evmuniV4_stateview.ini

e097c4c

Deleted due to naming fix

Add files via upload

3a55c6a

Naming fix

Add files via upload

60a08b8

Liquidity pools list management class added, UniswapV4 improvements.

Delete uniswap/uni4base.py

69cc90d

refactor

Delete uniswap/configs/chains.ini

dd7ae62

refactor

Delete uniswap/configs directory

a763a66

refactor

Beta

c7a4173

refactoring+bug fixes

Add files via upload

0f9a3ed

Add files via upload

567a8c7

Delete uniswap/v4pools.py

60675b0

moved to util

Delete uniswap/v4types.py

eb0cab0

moved to types

Delete uniswap/v4constants.py

bd546e8

moved to constants

liquid-8 and others added 11 commits July 15, 2026 16:19

unversal router execute() test fix

f709663

Maintenance update

475ed70

Add router v2.1.1 support; add X Layer, Tempo, Robinhood networks support; remove Blast and testnets support.

Add ReservesLens support

029b6c9

draft fixes

b590ebe

getPoolTVLBatch fix

1ca223c

getPoolTVLBatch params refactoring

3ddc049

docstring clarification

5edf31a

Fix ruff versions clownshow; docstring clarificatiom

a9490e1

Add ReservesLens support

dd1a0b8

Also minor improvements and docstring clarification.

test: switch mainnet RPC in CI tests (#484)

ab467cd

liquid-8 changed the title ~~D1 & D2 UF~~ D1 [x] & D2 [ ] UF Oct 11, 2026

greptile-apps Bot reviewed Oct 11, 2026

View reviewed changes

liquid-8 closed this Oct 11, 2026

liquid-8 changed the title ~~D1 [x] & D2 [ ] UF~~ D1 UF grant Oct 14, 2026

liquid-8 reopened this Oct 14, 2026

greptile-apps Bot reviewed Oct 14, 2026

View reviewed changes

README update (#489)

6711d56

* test: switch mainnet RPC in CI tests * README update

liquid-8 added 2 commits October 14, 2026 14:28

Merge branch 'master' into dev/v4-fin

087e2c7

asyncuniswap test fixture fix (#490)

aad7a59

* test: switch mainnet RPC in CI tests * README update * async_uniswap fixture fix

TimeToBuildBob mentioned this pull request Oct 14, 2026

feat(v4): UF grant work — async clients, ReservesLens, CI/test fixes (clean branch) #491

Merged

ErikBjare closed this Oct 14, 2026

	pools.fetch_poolkey_data(chunk_size=2000)
	pools.fetch_poolkey_data(first_block=21688329, chunk_size=2000)

-    tx = uni.mint_position(
+    approval_tx = uni.approve(USDC, approve_position_manager=True)
+    approval_receipt = uni.w3.eth.wait_for_transaction_receipt(approval_tx)
+    assert approval_receipt["status"]
+    tx = uni.mint_position(

Conversation

liquid-8 commented Oct 11, 2026

Uh oh!

codecov Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

greptile-apps Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 0/5

Findings

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot Oct 11, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 11, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 11, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 11, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

liquid-8 commented Oct 14, 2026

Uh oh!

ErikBjare commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liquid-8 commented Oct 14, 2026

Uh oh!

ErikBjare commented Oct 14, 2026

Uh oh!

TimeToBuildBob commented Oct 14, 2026

Uh oh!

ErikBjare commented Oct 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 11, 2026 •

edited

Loading

greptile-apps Bot commented Oct 11, 2026 •

edited

Loading

ErikBjare commented Oct 14, 2026 •

edited

Loading