feat: uniswap-trading AI-agent skill (D3 skeleton) - #478

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.61%. Comparing base (02c0368) to head (25ec81e).

@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          14       14           
  Lines        4302     4302           
=======================================
  Hits         3038     3038           
  Misses       1264     1264           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Greptile Summary

The PR adds an agent-oriented Uniswap trading skill with a subprocess CLI, safety gates, documentation, an offline test suite, and a Sepolia demo scaffold.

• Supports status, quote, swap, balance, and approval operations across Uniswap versions 2–4.
• Keeps state-changing operations dry-run by default and gates broadcasts by network, private-key availability, and slippage.
• Validates configured wallet addresses before balance client construction.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the current balance path rejects absent, malformed, and zero wallet addresses before constructing the client.

Important Files Changed

_{Reviews (3): Last reviewed commit: "fix(skill): validate balance wallet addr..." | Re-trigger Greptile}

@greptileai review

@greptileai review

CI failure analysis (session b7c3)

The 3 failing tests are pre-existing failures unrelated to this PR:

tests/test_uniswap.py::TestUniswap::test_get_price_output[1-ETH-UNI-1000000000000000000] FAILED
tests/test_uniswap.py::TestUniswap::test_get_price_output[1-UNI-ETH-10000000000000000]  FAILED
tests/test_uniswap.py::TestUniswap::test_get_price_output[1-ETH-UNI-2000000000000000000] FAILED

Root cause: EVM error InvalidJump from the Uniswap v1 UNI exchange contract (0x6fa90CcE27Bba2535B9329e340FD0cCebd358100) when calling getEthToTokenOutputPrice. This indicates the contract likely has no remaining liquidity — calling the v1 price output function with zero liquidity causes an InvalidJump in the Vyper bytecode.

Evidence these are pre-existing:

• The same 3 tests failed on run 33101882352 (the very first push on this branch, before any skill-specific commits were added)
• This branch only adds files in skills/uniswap-trading/ — no changes to tests/test_uniswap.py or the uniswap/ library
• All skill-specific tests pass: skills/uniswap-trading/tests/test_safety_gates.py — 20/20 ✅

Suggested fix: Mark these v1 ETH-UNI output price tests with @pytest.mark.xfail(reason="Uniswap v1 UNI exchange has no liquidity — InvalidJump", strict=False) to keep CI green without hiding the underlying issue.

Folded in corrections from a cross-agent dogfood round (Gordon, a trading-focused agent on our infra, ran the branch end-to-end: clean install, all tests passing, working mainnet v3/v4 quotes plus Polygon v3 quoting on the 0.05% WETH/USDC.e pool — and plans to replace ~150 LOC of his own swap tooling with this once released):

• Human-readable amounts: quote/swap/balance JSON now carries advisory <field>_human + decimals_<field> companions (best-effort ERC-20 decimals(); omitted rather than fatal on lookup failure — integer base-unit fields remain the source of truth)
• Deterministic v3-testnet refusal: v3 on testnets now exits 2 (safety, non-retryable) with an explanation, instead of surfacing the mainnet-hardcoded contract addresses as a retryable-looking BadFunctionCallOutput
• Setup docs install from this branch until a release contains the skill
• Double-armed mainnet broadcast: non-testnet broadcasting now requires BOTH UNISWAP_AGENT_ALLOW_MAINNET=1 (operator's standing decision) AND --allow-mainnet per call

Tests 18 → 28; verified live against public RPCs (mainnet quote with human fields, Sepolia refusal, single-arm broadcast refusal). The dogfood run itself doubles as early adoption evidence for the D3 baseline: two independent agent integrations (gptme, plus Gordon's trading stack) across two chains.

Follow-up for the red test (v1, mainnet) check: the 3 failures are pre-existing on master — the v1 UNI exchange contract has no remaining liquidity (EVM error InvalidJump), unrelated to this branch. Opened #479 to xfail those cases on master so CI goes green here and for every future PR; once merged, re-running this PR's checks should show fully green. No re-diagnosis needed.

Rebased onto current master (post-#491). The five CI/test-fix commits that used to sit under the skill were #479's content and are superseded by #491, so this PR now carries only the five skill commits: skills/uniswap-trading/ (824 lines, no library changes). Offline safety-gate tests: 28 passed. Mergeable again.