deal with a handful of warnings

benfry · benfry · commit e683d04d69c6 · 2017-02-03T11:58:22.000-05:00
diff --git a/java/src/processing/mode/java/Debugger.java b/java/src/processing/mode/java/Debugger.java
@@ -1407,7 +1407,7 @@ private void loge(String msg, Throwable t) {
   }
 
 
-  private void logitse(Throwable t) {
+  static private void logitse(Throwable t) {
     Messages.loge("incompatible thread state?", t);
   }
 
diff --git a/java/src/processing/mode/java/pdex/PreprocessingService.java b/java/src/processing/mode/java/pdex/PreprocessingService.java
@@ -72,7 +72,6 @@
 /**
  * The main error checking service
  */
-@SuppressWarnings("unchecked")
 public class PreprocessingService {
 
   protected final JavaEditor editor;
@@ -93,7 +92,7 @@ public class PreprocessingService {
   private CompletableFuture<PreprocessedSketch> preprocessingTask = new CompletableFuture<>();
 
   private CompletableFuture<?> lastCallback =
-      new CompletableFuture() {{
+      new CompletableFuture<Object>() {{
         complete(null); // initialization block
       }};
 
@@ -568,8 +567,8 @@ private static List<String> buildSearchLibraryClassPath(JavaMode mode) {
   }
 
 
-  private List<String> buildSketchLibraryClassPath(JavaMode mode,
-                                                   List<ImportStatement> programImports) {
+  static private List<String> buildSketchLibraryClassPath(JavaMode mode,
+                                                          List<ImportStatement> programImports) {
     StringBuilder classPath = new StringBuilder();
 
     programImports.stream()
@@ -590,7 +589,7 @@ private List<String> buildSketchLibraryClassPath(JavaMode mode,
   }
 
 
-  private List<String> buildJavaRuntimeClassPath() {
+  static private List<String> buildJavaRuntimeClassPath() {
     StringBuilder classPath = new StringBuilder();
 
     // Java runtime
@@ -654,7 +653,7 @@ private static CompilationUnit makeASTWithBindings(ASTParser parser,
   /**
    * Ignore processing packages, java.*.*. etc.
    */
-  private boolean ignorableImport(String packageName) {
+  static private boolean ignorableImport(String packageName) {
     return (packageName.startsWith("java.") ||
             packageName.startsWith("javax."));
   }
diff --git a/java/src/processing/mode/java/runner/Runner.java b/java/src/processing/mode/java/runner/Runner.java
@@ -127,7 +127,7 @@ public Runner(JavaBuild build, RunnerListener listener) throws SketchException {
    * Has the user screwed up their hosts file?
    * https://github.com/processing/processing/issues/4738
    */
-  private void checkLocalHost() throws SketchException {
+  static private void checkLocalHost() throws SketchException {
     try {
       InetAddress address = InetAddress.getByName("localhost");
       if (!address.getHostAddress().equals("127.0.0.1")) {

Original file line number	Diff line number	Diff line change
`@@ -1407,7 +1407,7 @@ private void loge(String msg, Throwable t) {`
`1407`	`1407`	`}`
`1408`	`1408`
`1409`	`1409`
`1410`		`- private void logitse(Throwable t) {`
	`1410`	`+ static private void logitse(Throwable t) {`
`1411`	`1411`	`Messages.loge("incompatible thread state?", t);`
`1412`	`1412`	`}`
`1413`	`1413`