Conversation
un33k
requested changes
Feb 22, 2022
Owner
un33k
left a comment
There was a problem hiding this comment.
@mrezzamoradi Everything looks great.
Could you also update the following files to reflect your changes since you have access to the main repo.
1 - Changelog
2 - Readme (add unicode usecase)
3 - version.py file (6.0.1 -> 6.1.0) [new feature, backward compatible]
It should be ready after the above.
I can also do the above, however, it would be best if it comes in as part of the original PR.
Thank you.
un33k
approved these changes
Feb 22, 2022
Owner
|
Merged in, pushed to sandbox, ci and master. Official push to pypi. Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This non-intrusive change gives users the choice to allow Unicode characters in the final slug. I understand it might not be aligned with the initial goal of this project (URL path slugification), still I think it has valid use cases like when applications use slugified strings as filenames, e.g. exporting a google doc to PDF. The filename can contain Unicode. Some popular projects like Djange have this feature
Changes:
allow_unicodeparameter with default to False.DISALLOWED_UNICODE_CHARS_PATTERNregex pattern to filter out non-words.allow_unicodeflag on to make sure the behaviour is unchanged.If you approve this proposal, then I or you can update the README file accordingly. We then need to modify the Wiki a bit as well.
solves #78
solves #24