Skip to content

feat(stovepipe): extend Request entity to support new process step#319

Open
mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-queue-storefrom
mnoah1/stovepipe-request-entity
Open

feat(stovepipe): extend Request entity to support new process step#319
mnoah1 wants to merge 1 commit into
mnoah1/stovepipe-queue-storefrom
mnoah1/stovepipe-request-entity

Conversation

@mnoah1

@mnoah1 mnoah1 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

What?

Updating the Request entity to accommodate upcoming functionality in the process step:

  • New RequestState values - processing once the processing step has started, and superseded for requests that will be skipped in favor of building a newer one
  • BuildStrategy/BaseURI fields which will get populated by the process process for downstream use during builds
  • Since request IDs are minted in order by ingest, I realized it's a bit redundant to store a separate sequence ID in the DB. Instead, define a CompareRequestID function for cases that require ID comparison, and converge to just storing the ID.

Why?

Implementing behavior in https://github.com/uber/submitqueue/blob/main/doc/rfc/stovepipe/steps/process.md - which introduces two new outcome states and includes logic to determine the build strategy for a request.

Test Plan

  • Unit tests
  • Subsequent changes will pull this logic together into an end to end flow

@mnoah1 mnoah1 marked this pull request as ready for review July 8, 2026 21:19
@mnoah1 mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners July 8, 2026 21:19
@mnoah1 mnoah1 changed the title feat(stovepipe): extend Request entity and MySQL storage feat(stovepipe): extend Request entity to support new process step Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant