chore(bazel): add go_default_library alias for downstream naming compatibility#299
Closed
roychying wants to merge 1 commit into
Closed
chore(bazel): add go_default_library alias for downstream naming compatibility#299roychying wants to merge 1 commit into
roychying wants to merge 1 commit into
Conversation
|
chenghan.ying seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
Author
|
Close this one. Adopt #295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Some Bazel-based downstream consumers of this repo enforce their own naming convention where Go targets must be named
go_default_library/go_default_test. When such a consumer uses our checked-in BUILD files directly (rather than regenerating them), our native target names don't satisfy that convention, so their consumer labels fail to resolve.We need a fix that satisfies that requirement without renaming our own targets or breaking any other Bazel consumer relying on the native names.
This PR is addressing the same issue as #295 but use alias approach which is cheaper and less invasive.
What?
Adds
# gazelle:go_naming_convention import_aliasto the rootBUILD.bazeland regenerates all BUILD files viamake gazelle.Test Plan
Issue