Repository navigation
fix: preserve single-knot KTR predictions with uncertainty - #896
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
Shubham-Padkonde
marked this pull request as ready for review
September 22, 2026 05:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #816.
KTR prediction with
level_segments=0accesses a nonexistent second level knot wheninclude_error=True. Only extrapolate level knots when at least two knots exist. Single-knot predictions use the existing constant interpolation kernel; observation noise remains enabled.Regression tests cover in-sample and future dates, one and three posterior samples, and predictions with and without observation noise. They also check that prediction leaves posterior levels unchanged.
Type of change
How Has This Been Tested?
python -m pytest tests/orbit/utils/test_knots.py tests/orbit/models/test_ktr.py -k 'single_level_knot or test_knots' -q— 29 passed.black --check orbit/template/ktr.py tests/orbit/models/test_ktr.py— passed.git diff --check— passed.No dependency changes. Prepared with Codex assistance.