fix: handle union response in post_multi_search for conversations#2848
Merged
kishorenc merged 8 commits intotypesense:v31from Apr 20, 2026
Merged
fix: handle union response in post_multi_search for conversations#2848kishorenc merged 8 commits intotypesense:v31from
kishorenc merged 8 commits intotypesense:v31from
Conversation
kishorenc
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
POST /multi_searchwithunion=true&conversation=truewas sending empty data to the conversation model.CollectionManager::do_union()writes results as top-levelhits, not aresults[]array. The conversation post-processing only iteratedresponse["results"], which doesn't exist in union responses, so the model always received[].The fix adds a dedicated branch for the union case that reads documents from the top-level
hitsarray and gathers vector fields from all collections involved in the union.Test Plan
test/dummy_model_server.py) that logs the full request body received from TypesensePOST /multi_search?conversation=true&union=truewith two searches againsthnstories, the model received[](empty data) even though the union search found hits. The response also contained"results": nullPR Checklist