Skip to content

fix(eslint-plugin): [no-unsafe-argument] handle tagged templates#8746

Merged
JoshuaKGoldberg merged 6 commits into
typescript-eslint:mainfrom
yeonjuan:fixes/8745
Apr 23, 2024
Merged

fix(eslint-plugin): [no-unsafe-argument] handle tagged templates#8746
JoshuaKGoldberg merged 6 commits into
typescript-eslint:mainfrom
yeonjuan:fixes/8745

Conversation

@yeonjuan
Copy link
Copy Markdown
Contributor

@yeonjuan yeonjuan commented Mar 21, 2024 •
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Copy Markdown
Contributor

typescript-eslint Bot commented Mar 21, 2024

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7351ba6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6617f8792341cd00083dc741
😎 Deploy Preview https://deploy-preview-8746--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 21, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7351ba6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.40%. Comparing base (ecae04f) to head (527358a).
Report is 68 commits behind head on main.

❗ Current head 527358a differs from pull request most recent head 7351ba6. Consider uploading reports for the commit 7351ba6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8746      +/-   ##
==========================================
+ Coverage   87.38%   87.40%   +0.01%     
==========================================
  Files         254      254              
  Lines       12489    12491       +2     
  Branches     3919     3919              
==========================================
+ Hits        10914    10918       +4     
+ Misses       1304     1302       -2     
  Partials      271      271
Flag Coverage Δ
unittest 87.40% <94.59%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 86.41% <94.59%> (+2.87%) ⬆️

@yeonjuan yeonjuan marked this pull request as ready for review March 22, 2024 16:27
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat(eslint-plugin): [no-unsafe-argument] handle tagged templates fix(eslint-plugin): [no-unsafe-argument] handle tagged templates Mar 25, 2024
@bradzacher bradzacher added the bug Something isn't working label Apr 4, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is actually not that bad 😄 just indentation changes. I like the strategy of extracting to checkUnsafeArguments. Very reasonable.

Marking as 1 approval for a bit. Thanks! 🎉

Comment thread packages/eslint-plugin/src/rules/no-unsafe-argument.ts
@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 8, 2024
auvred
auvred previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

JoshuaKGoldberg
JoshuaKGoldberg reviewed Apr 10, 2024
View reviewed changes
Comment thread packages/eslint-plugin/src/rules/no-unsafe-argument.ts Outdated
JoshuaKGoldberg
JoshuaKGoldberg requested changes Apr 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close! just the test, I think?

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Apr 10, 2024
@github-actions github-actions Bot removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 11, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rainbow rings of wacky inflatable arm tubes, waving, around the word "YIPPEE!"

@JoshuaKGoldberg JoshuaKGoldberg merged commit b0f7aa4 into typescript-eslint:main Apr 23, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@auvred auvred auvred left review comments

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [no-unsafe-argument] Check unsafe arguments in Tagged templates

4 participants

@yeonjuan @JoshuaKGoldberg @auvred @bradzacher