Repository navigation
chore(website): add details to Configurations page - #5719
Merged
bradzacher merged 8 commits intoNov 23, 2022
Merged
Conversation
Contributor
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JoshuaKGoldberg
marked this pull request as ready for review
October 16, 2022 02:50
bradzacher
requested changes
Oct 24, 2022
bradzacher
left a comment
Member
There was a problem hiding this comment.
Looks like the build is failing.
[!] Error: 'Linter' is not exported by ../../node_modules/eslint/lib/api.js, imported by src/linter/linter.js
https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module
src/linter/linter.js (2:0)
1: import 'vs/language/typescript/tsWorker';
2: import { Linter } from 'eslint';
^
3: import rules from '@typescript-eslint/eslint-plugin/dist/rules';
Error: 'Linter' is not exported by ../../node_modules/eslint/lib/api.js, imported by src/linter/linter.js
at error (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:198:30)
at Module.error (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:12560:16)
at Module.traceVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:12919:29)
at ModuleScope.findVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:11571:39)
at FunctionScope.findVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:6503:38)
at ChildScope.findVariable (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:6503:38)
at Identifier.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:7570:40)
at NewExpression.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:5400:23)
at VariableDeclarator.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:5400:23)
at VariableDeclaration.bind (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/rollup/dist/shared/rollup.js:5396:73)
Something in this PR has introduced the error I think cos it's not broken on main
bradzacher
reviewed
Oct 24, 2022
Member
Author
|
Grr, I was really hoping that config was from some kind of caching issue. |
JoshuaKGoldberg
marked this pull request as draft
October 24, 2022 19:15
JoshuaKGoldberg
marked this pull request as ready for review
October 24, 2022 19:26
bradzacher
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
Reworks the Configurations page to emphasize the recommended configs. Also mention the
allandbaseconfigs alongsideeslint-recommendedas "other" (utility) configs, and adds the Prettified, stringified contents of each config to the page.