Skip to content

Update sip.py to include 417 SIP Response Code - #12299

Open
medOualla wants to merge 2 commits into
twisted:trunkfrom
medOualla:patch-1
Open

medOualla wants to merge 2 commits into
twisted:trunkfrom
medOualla:patch-1

Conversation

@medOualla

Copy link
Copy Markdown

417 SIP Response code belonging to the 4XX SIP Negative replies from RFC 4412. Source: https://datatracker.ietf.org/doc/html/rfc4412

Scope and purpose

Fixes #

Add the 417 Response code in case we want to test an SBC or SIP entity for all possible SIP Responses.
RFC 4412 details this response code, link "https://datatracker.ietf.org/doc/html/rfc4412"

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

medOualla and others added 2 commits August 28, 2024 17:45
417 SIP Response code belonging to the 4XX SIP Negative replies from RFC 4412.
Source: https://datatracker.ietf.org/doc/html/rfc4412
@codspeed

codspeed Bot commented Aug 28, 2024 •

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #12299 will not alter performance

Comparing medOualla:patch-1 (02ee481) with trunk (fff8761)

Summary

✅ 23 untouched benchmarks

@glyph

glyph commented Aug 29, 2024

Copy link
Copy Markdown
Member

Thanks for this contribution @medOualla ! Can you follow the instructions to file an issue and add a news fragment with an appropriate description so we can get this landed?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants